Skip to content

Conversation

mkingst
Copy link
Contributor

@mkingst mkingst commented Jan 10, 2025

Proposed changes

The module is no longer being developed since it was for ACM metrics. It is causing confusion due to the naming as folks think it's an NGINX module (NGINX Plus metrics). The references to NMS also indicate that it's needed for NIM, but it is not necessary for NIM metrics and is only used for EoS products (ACM, and eventually ADM).

The old NMS docs need to make it clear that this module is no longer being developed and is not required for NIM. If customers are using NGINX Plus >R33 they should not need to consider this module, or remove it if they need to use new NGINX Plus versions.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mkingst mkingst requested a review from a team as a code owner January 10, 2025 14:40
Copy link

github-actions bot commented Jan 10, 2025

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


1 out of 2 committers have signed the CLA.
✅ (Jcahilltorre)[https://github.com/Jcahilltorre]
@mkingst
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/60/

@JTorreG JTorreG merged commit 876f2b9 into main Jan 10, 2025
2 of 3 checks passed
@JTorreG JTorreG deleted the mkingst--eos-metrics-module branch January 10, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants