Skip to content

fix: replace incorrect 'NGINX One' labels with 'NGINX One Console' where appropriate #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025

Conversation

shekhar-11
Copy link
Contributor

Reviewed multiple documentation files and replaced instances of "NGINX One" with "NGINX One Console" where appropriate—specifically when referring to the management interface or API

Testing:

     ------Verified that all changes are in Markdown content only
     ------No structural or logic-level changes were made

@shekhar-11 shekhar-11 requested a review from a team as a code owner July 18, 2025 10:11
Copy link

github-actions bot commented Jul 18, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console product/agent Issues related to NGINX Agent product/mesh Issues related to NGINX Service Mesh (EOS product) labels Jul 18, 2025
@shekhar-11
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@shekhar-11
Copy link
Contributor Author

Hi maintainers,

This PR updates documentation by replacing "NGINX One" with "NGINX One Console" in cases where it refers specifically to the management interface or API. All changes are Markdown-only and non-breaking.

I've signed the CLA ✅ and verified the updates follow the style guide.

Just submitting a kind request for review and workflow approval when convenient. Thank you!

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thank you. I'm going to leave the issue open. When I run

cd /path/to/documentation_repository
cd content
git grep "NGINX One"

I see a number of other instances worth investigating.

ADubhlaoich and others added 3 commits July 18, 2025 14:33
Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I would be happy to merge, though per @mjang this effort potentially has additional instances to fix, so I will leave it so the author has an opportunity to address them.

@mjang
Copy link
Contributor

mjang commented Jul 18, 2025

LGTM!

I would be happy to merge, though per @mjang this effort potentially has additional instances to fix, so I will leave it so the author has an opportunity to address them.

@ADubhlaoich These are valid changes. But I'm pretty sure there will be more, so I'm "unassigning" @shekhar-11 , and leaving #836 open.

Thank you @shekhar-11 , and congratulations on your first contribution to NGINX documentation!

@mjang mjang merged commit fea7686 into nginx:main Jul 18, 2025
7 checks passed
@mjang
Copy link
Contributor

mjang commented Jul 18, 2025

@shekhar-11 you're welcome to open more PRs if you want to investigate and fix more cases where we should replace "NGINX One" with "NGINX One Console".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation product/agent Issues related to NGINX Agent product/mesh Issues related to NGINX Service Mesh (EOS product) product/nginx-one Issues related to NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants