-
Notifications
You must be signed in to change notification settings - Fork 103
fix: replace incorrect 'NGINX One' labels with 'NGINX One Console' where appropriate #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
Hi maintainers, This PR updates documentation by replacing "NGINX One" with "NGINX One Console" in cases where it refers specifically to the management interface or API. All changes are Markdown-only and non-breaking. I've signed the CLA ✅ and verified the updates follow the style guide. Just submitting a kind request for review and workflow approval when convenient. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, thank you. I'm going to leave the issue open. When I run
cd /path/to/documentation_repository
cd content
git grep "NGINX One"
I see a number of other instances worth investigating.
Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I would be happy to merge, though per @mjang this effort potentially has additional instances to fix, so I will leave it so the author has an opportunity to address them.
@ADubhlaoich These are valid changes. But I'm pretty sure there will be more, so I'm "unassigning" @shekhar-11 , and leaving #836 open. Thank you @shekhar-11 , and congratulations on your first contribution to NGINX documentation! |
@shekhar-11 you're welcome to open more PRs if you want to investigate and fix more cases where we should replace "NGINX One" with "NGINX One Console". |
Reviewed multiple documentation files and replaced instances of "NGINX One" with "NGINX One Console" where appropriate—specifically when referring to the management interface or API
Testing: