-
Notifications
You must be signed in to change notification settings - Fork 101
Include JWT license reference to installing-nginx-docker.md #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
✅ Deploy Preview will be available once build job completes!
|
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there was an extra whitespace :)
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
…cker.md Co-authored-by: yar <y82@users.noreply.github.com>
…cker.md Co-authored-by: Alessandro Fael Garcia <alessfg@hotmail.com>
In my experience when folks use this page they navigate to a specific subsection directly. It's useful to reiterate out the necessary requirements 😄 |
Modern technical writing follows a practice known as "Every Page is Page One". @alessfg what you say makes sense, so we may need to think about this further (for longer pages like this) |
As suggested by @alessfg
Proposed changes
The docs for building the NGINX Plus Dockerfiles manually found here https://docs.nginx.com/nginx/admin-guide/installing-nginx/installing-nginx-docker#creating-custom-nginx-plus-docker-image need to be updated. Step 3 needs to mention downloading the JWT license in addition to the cert and key. The command in step 5 needs to be updated to:
Context
We may have a different problem, as we already cite these three files as prerequisites, per https://docs.nginx.com/nginx/admin-guide/installing-nginx/installing-nginx-docker/#prerequisites
But I get it:
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩