-
Notifications
You must be signed in to change notification settings - Fork 114
Remove card-layout from N+ landing page #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, Jack noted in a previous PR that the broken build in PRs against the current mainframe branch are -- not an issue.
We removed |
feat: Remove card-layout from N+ landing page
feat: Remove card-layout from N+ landing page
feat: Remove card-layout from N+ landing page
feat: Remove card-layout from N+ landing page
feat: Remove card-layout from N+ landing page
feat: Remove card-layout from N+ landing page
feat: Remove card-layout from N+ landing page
feat: Remove card-layout from N+ landing page
feat: Remove card-layout from N+ landing page
* Fix catalog and home page * Homepage: Match mainframe branch updates * Homepage: Match mainframe css and layout setup * Rewrite main landing page to be in markdown + updated card shortcode usage (#818) feat: Rewrote main landing page to be in markdown + updated card shortcode usage * Refactored icon usage to use new shortcode (#801) * feat: Rewrote main landing page to be in markdown + updated card shortcode usage * Update card params correctly * chore: Refactored icon usage to use new shortcode * Removed brand icons * Removed final few brand icons * Add overview of nginx-org source ingestion * Update N1 landing page to use updated params * Remove fa usages in mesh * Redocly: Match updated mainframe redocly usage (#970) * Update card-layout usage (#979) * chore: Remove card-layout shortcode usage * chore: Update NIC docs * Remove NGINX Unit from home landing page (#981) chore: Remove NGINX Unit from home landing page * feat: Update tables This commit updates tables across the NGINX documentation set by removing the old bootstrap shortcode or replacing it with the new table one. Mainframe has better sensible defaults, so the scaffolding provided by the bootstrap shortcode is no longer necessary. * Remove card-layout from N+ landing page (#996) feat: Remove card-layout from N+ landing page * Rebase: Fixes post rebase * CardLayout: Fix post rebase * fix: Icon for N4A on home landing page * Fix: Missing line break after includes * Fix OSSC page on mainframe (#1026) fix: Render of ossc page + updated contents * Remove sidebar partial (#1031) chore: Remove sidebar partial * Fix NMS rendering on mainframe (#1030) fix: NMS rendering on mainframe * Fix rn-style shortcode usage issues in build (#1032) fix: Fix rn-style shortcode usage issues in build * ProductSelector: Add yaml * Mainframe: Cardlayout rebase for n1 workshop * Mainframe: Update yaml * Remove before-you-begin shortcode (#1036) chore: Remove before-you-begin shortcode * ProductSelector: Supply extUrl prop for external urls * ProductSelector: Fix casing * ProductSelector: Remove prefix / * ProductSelector: Remove prefix / * ProductSelector: Remove unit --------- Co-authored-by: Lam <150060045+lamATnginx@users.noreply.github.com> Co-authored-by: Lam Nguyen <la.nguyen@f5.com> Co-authored-by: Alan Dooley <a.dooley@f5.com> Co-authored-by: Michael McKeen <m.mckeen@f5.com>
Proposed changes
Remove
card-layout
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩