Skip to content

Conversation

lamATnginx
Copy link
Contributor

Proposed changes

Remove card-layout

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@lamATnginx lamATnginx self-assigned this Aug 19, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner August 19, 2025 20:30
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) labels Aug 19, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, Jack noted in a previous PR that the broken build in PRs against the current mainframe branch are -- not an issue.

@lamATnginx
Copy link
Contributor Author

IIRC, Jack noted in a previous PR that the broken build in PRs against the current mainframe branch are -- not an issue.

We removed card-layout in the mainframe branch of the theme so this change is updating the landing page for it. We didn't update it on main branch theme cuz it can lead to some merge conflicts that overly complicate mainframe branch.

@lamATnginx lamATnginx merged commit 840b436 into mainframe Aug 19, 2025
6 of 7 checks passed
@lamATnginx lamATnginx deleted the plus-landing-cleanup branch August 19, 2025 22:38
nginx-jack pushed a commit that referenced this pull request Aug 20, 2025
feat: Remove card-layout from N+ landing page
nginx-jack pushed a commit that referenced this pull request Aug 20, 2025
feat: Remove card-layout from N+ landing page
nginx-jack pushed a commit that referenced this pull request Aug 22, 2025
feat: Remove card-layout from N+ landing page
nginx-jack pushed a commit that referenced this pull request Aug 25, 2025
feat: Remove card-layout from N+ landing page
nginx-jack pushed a commit that referenced this pull request Aug 27, 2025
feat: Remove card-layout from N+ landing page
nginx-jack pushed a commit that referenced this pull request Aug 28, 2025
feat: Remove card-layout from N+ landing page
nginx-jack pushed a commit that referenced this pull request Aug 29, 2025
feat: Remove card-layout from N+ landing page
nginx-jack pushed a commit that referenced this pull request Sep 2, 2025
feat: Remove card-layout from N+ landing page
nginx-jack pushed a commit that referenced this pull request Sep 2, 2025
feat: Remove card-layout from N+ landing page
nginx-jack added a commit that referenced this pull request Sep 2, 2025
* Fix catalog and home page

* Homepage: Match mainframe branch updates

* Homepage: Match mainframe css and layout setup

* Rewrite main landing page to be in markdown + updated card shortcode usage (#818)

feat: Rewrote main landing page to be in markdown + updated card shortcode usage

* Refactored icon usage to use new shortcode (#801)

* feat: Rewrote main landing page to be in markdown + updated card shortcode usage

* Update card params correctly

* chore: Refactored icon usage to use new shortcode

* Removed brand icons

* Removed final few brand icons

* Add overview of nginx-org source ingestion

* Update N1 landing page to use updated params

* Remove fa usages in mesh

* Redocly: Match updated mainframe redocly usage (#970)

* Update card-layout usage (#979)

* chore: Remove card-layout shortcode usage

* chore: Update NIC docs

* Remove NGINX Unit from home landing page (#981)

chore: Remove NGINX Unit from home landing page

* feat: Update tables

This commit updates tables across the NGINX documentation set by
removing the old bootstrap shortcode or replacing it with the new table
one. Mainframe has better sensible defaults, so the scaffolding provided
by the bootstrap shortcode is no longer necessary.

* Remove card-layout from N+ landing page (#996)

feat: Remove card-layout from N+ landing page

* Rebase: Fixes post rebase

* CardLayout: Fix post rebase

* fix: Icon for N4A on home landing page

* Fix: Missing line break after includes

* Fix OSSC page on mainframe (#1026)

fix: Render of ossc page + updated contents

* Remove sidebar partial (#1031)

chore: Remove sidebar partial

* Fix NMS rendering on mainframe (#1030)

fix: NMS rendering on mainframe

* Fix rn-style shortcode usage issues in build (#1032)

fix: Fix rn-style shortcode usage issues in build

* ProductSelector: Add yaml

* Mainframe: Cardlayout rebase for n1 workshop

* Mainframe: Update yaml

* Remove before-you-begin shortcode (#1036)

chore: Remove before-you-begin shortcode

* ProductSelector: Supply extUrl prop for external urls

* ProductSelector: Fix casing

* ProductSelector: Remove prefix /

* ProductSelector: Remove prefix /

* ProductSelector: Remove unit

---------

Co-authored-by: Lam <150060045+lamATnginx@users.noreply.github.com>
Co-authored-by: Lam Nguyen <la.nguyen@f5.com>
Co-authored-by: Alan Dooley <a.dooley@f5.com>
Co-authored-by: Michael McKeen <m.mckeen@f5.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants