Skip to content

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 24, 2024

Proposed changes

  • add v5 image to regression CI
  • add skip_oss marker to waf v5 test

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner September 24, 2024 09:25
@vepatel vepatel changed the title add v5 image fix regression job Sep 24, 2024
@github-actions github-actions bot added python Pull requests that update Python code github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks tests Pull requests that update tests labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.24%. Comparing base (fdedba6) to head (7b217e6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6489      +/-   ##
==========================================
+ Coverage   53.21%   53.24%   +0.02%     
==========================================
  Files          85       85              
  Lines       16016    16016              
==========================================
+ Hits         8523     8527       +4     
+ Misses       7085     7083       -2     
+ Partials      408      406       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vepatel vepatel enabled auto-merge (squash) September 24, 2024 09:37
@vepatel vepatel merged commit f9bc296 into main Sep 24, 2024
80 checks passed
@vepatel vepatel deleted the tests/fix-regression-job branch September 24, 2024 10:30
@pdabelf5 pdabelf5 added skip changelog Pull requests that don't need to be added to the changelog and removed python Pull requests that update Python code github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks tests Pull requests that update tests labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Pull requests that don't need to be added to the changelog
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants