Skip to content

Conversation

javorszky
Copy link
Contributor

This is a mirror of #7131 so tests have access to secrets

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

These experimental packages are now available in the Go standard
library:

	1. golang.org/x/exp/slices -> slices [1]
	2. golang.org/x/exp/maps -> maps [2]

[1]: https://go.dev/doc/go1.21#slices
[2]: https://go.dev/doc/go1.21#maps

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.72%. Comparing base (5972517) to head (a5e6810).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7142      +/-   ##
==========================================
- Coverage   52.73%   52.72%   -0.01%     
==========================================
  Files          89       89              
  Lines       20843    20843              
==========================================
- Hits        10992    10990       -2     
  Misses       9394     9394              
- Partials      457      459       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javorszky
Copy link
Contributor Author

Original merged 🙂

@javorszky javorszky closed this Jan 16, 2025
@pdabelf5 pdabelf5 deleted the do-not-merge/refactor/ext branch May 15, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants