Skip to content

Allow customization of service http and https port names through helm #7318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Allow customization of service http and https port names through helm #7318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37a9d91
allow customization of service http and https port names through helm…
arussellf5 Feb 6, 2025
d7937fa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/nginx-ingress/templates/controller-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
- port: {{ .Values.controller.service.httpPort.port }}
targetPort: {{ .Values.controller.service.httpPort.targetPort }}
protocol: TCP
name: http
name: {{ .Values.controller.service.httpPort.name }}
{{- if or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort") }}
nodePort: {{ .Values.controller.service.httpPort.nodePort }}
{{- end }}
Expand All @@ -58,7 +58,7 @@ spec:
- port: {{ .Values.controller.service.httpsPort.port }}
targetPort: {{ .Values.controller.service.httpsPort.targetPort }}
protocol: TCP
name: https
name: {{ .Values.controller.service.httpsPort.name }}
{{- if or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort") }}
nodePort: {{ .Values.controller.service.httpsPort.nodePort }}
{{- end }}
Expand Down
28 changes: 24 additions & 4 deletions charts/nginx-ingress/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,14 +1346,23 @@
"examples": [
80
]
},
"name": {
"type": "string",
"default": "http",
"title": "The httpPort name",
"examples": [
"http"
]
}
},
"examples": [
{
"enable": true,
"port": 80,
"nodePort": "",
"targetPort": 80
"targetPort": 80,
"name": "http"
}
]
},
Expand Down Expand Up @@ -1396,12 +1405,21 @@
]
}
},
"name": {
"type": "string",
"default": "https",
"title": "The httpsPort name",
"examples": [
"https"
]
},
"examples": [
{
"enable": true,
"port": 443,
"nodePort": "",
"targetPort": 443
"targetPort": 443,
"name": "https"
}
]
},
Expand Down Expand Up @@ -1432,12 +1450,14 @@
"httpPort": {
"enable": true,
"port": 80,
"targetPort": 80
"targetPort": 80,
"name": "http"
},
"httpsPort": {
"enable": true,
"port": 443,
"targetPort": 443
"targetPort": 443,
"name": "https"
},
"customPorts": []
}
Expand Down
6 changes: 6 additions & 0 deletions charts/nginx-ingress/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,9 @@ controller:
## The HTTP port on the POD where the Ingress Controller service is running.
targetPort: 80

## The name of the HTTP port.
name: "http"

httpsPort:
## Enables the HTTPS port for the Ingress Controller service.
enable: true
Expand All @@ -491,6 +494,9 @@ controller:
## The HTTPS port on the POD where the Ingress Controller service is running.
targetPort: 443

## The name of the HTTPS port.
name: "https"

## A list of custom ports to expose through the Ingress Controller service. Follows the conventional Kubernetes yaml syntax for service ports.
customPorts: []

Expand Down
Loading