Align with BackendTLSPolicy validation #3871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The BackendTLSPolicy spec was updated to include specific rules around certificate validation that we were not adhering to
Solution: Update our validation and conditions to match the updated spec
Testing: Local, unit, and conformance testing
-> see https://github.com/nginx/nginx-gateway-fabric/actions/runs/17551266824/job/49845122033?pr=3871
NOTE:
BackendTLSPolicyObservedGenerationBump/observedGeneration_should_increment
is failing due to what looks like a test fixtures failure as the error is related to not being able to find the ConfigMap - this is not related to the validation changes and will be followed up I a separate ticketCloses #3651
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.