Skip to content

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Sep 18, 2025

Proposed changes

Cherry-pick for 3936

Closes #3936

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Fixed an issue where a failed configuration reload caused all HTTPRoutes to be marked as invalid (Accepted: false). This led to external-dns removing DNS records even though the configuration had been rolled back. Routes now retain their valid state during reload failures, preventing unnecessary DNS disruptions.

Problem: When nginx reload fails, all routes are marked invalid

Solution: Remove adding GatewayNotProgrammed condition to routes since the error should only be reflected on Gateway Listener conditions
@salonichf5 salonichf5 requested a review from a team as a code owner September 18, 2025 22:03
@github-actions github-actions bot added bug Something isn't working tests Pull requests that update tests labels Sep 18, 2025
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.88%. Comparing base (c68b52a) to head (8334405).
⚠️ Report is 1 commits behind head on release-2.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.1    #3938      +/-   ##
===============================================
+ Coverage        86.86%   86.88%   +0.01%     
===============================================
  Files              128      128              
  Lines            16029    16013      -16     
  Branches            62       62              
===============================================
- Hits             13924    13913      -11     
+ Misses            1936     1930       -6     
- Partials           169      170       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 merged commit f76e38f into release-2.1 Sep 19, 2025
44 checks passed
@salonichf5 salonichf5 deleted the bug/cherry-pick-httproute branch September 19, 2025 14:47
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-notes tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants