-
Notifications
You must be signed in to change notification settings - Fork 137
Add Dockerfiles to build images from UBI9 minimal #3941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/openshift-support #3941 +/- ##
=========================================================
Coverage ? 86.81%
=========================================================
Files ? 128
Lines ? 16602
Branches ? 62
=========================================================
Hits ? 14413
Misses ? 2007
Partials ? 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In the most recent commit, The build also uses Without that change, we saw this error occur when running
Also, I understand it's probably not desirable from a security standpoint to have any dir with full 777 permissions. |
…les to `build/alpine`
@shaun-nx What else is writing to |
That's a good point. Agent itself was throwing the same error though, not just ps -ef. I'll test that out again though and see what happens |
Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
Proposed changes
This change adds three new Dockerfiles that can be used to build NGF, NGINX Open Source, and NGINX Plus with
ub9-minimal
as the base image.Docker files are now organized into folders by the base image they use (e.g. alpine, ubi, etc...)
This allows us to using the
BUILD_OS
arg in ourMakefile
to build imaged from different base images.To build both NGf and NGINX Opnesource using the UBI based Dockerfiles:
BUILD_OS
defaults toalpine
Closes #3906
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.