Skip to content

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Sep 25, 2025

Proposed changes

This change updates our build pipeline to build our UBI based images

Closes #3914

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 25, 2025
@shaun-nx shaun-nx changed the base branch from main to feat/openshift-support September 25, 2025 11:10
@shaun-nx shaun-nx changed the base branch from feat/openshift-support to feat/ubi-base-image September 25, 2025 11:10
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/openshift-support@b0cf702). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             feat/openshift-support    #3958   +/-   ##
=========================================================
  Coverage                          ?   86.80%           
=========================================================
  Files                             ?      128           
  Lines                             ?    16602           
  Branches                          ?       62           
=========================================================
  Hits                              ?    14412           
  Misses                            ?     2008           
  Partials                          ?      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Sep 25, 2025
Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a couple of more comments and we should be nearly there 🎉

I created a separate ticket to address the failing functional test: #3981

@shaun-nx shaun-nx requested a review from ciarams87 October 1, 2025 07:57
@shaun-nx
Copy link
Contributor Author

shaun-nx commented Oct 1, 2025

Great work! Just a couple of more comments and we should be nearly there 🎉

I created a separate ticket to address the failing functional test: #3981

Thanks @ciarams87 !

Tried a few things to make that test pass.
One was to use the full redhat/ubi9 image instead of the minimal.
Also tried installing additional libraries that may be required for that test. Both of these approaches didn't resolve the failing tests.

I've un-done both of those changes now.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice work, in the future would help to also include your testing done in the pr description

@shaun-nx shaun-nx merged commit 0189049 into feat/openshift-support Oct 2, 2025
89 of 90 checks passed
@shaun-nx shaun-nx deleted the feat/pipeline-ubi-builds branch October 2, 2025 07:23
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Build and publish UBI images in the pipeline

3 participants