-
Notifications
You must be signed in to change notification settings - Fork 137
Update pipeline to build and publish UBI images #3958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…able by nginx user
…les to `build/alpine`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/openshift-support #3958 +/- ##
=========================================================
Coverage ? 86.80%
=========================================================
Files ? 128
Lines ? 16602
Branches ? 62
=========================================================
Hits ? 14412
Misses ? 2008
Partials ? 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a couple of more comments and we should be nearly there 🎉
I created a separate ticket to address the failing functional test: #3981
Thanks @ciarams87 ! Tried a few things to make that test pass. I've un-done both of those changes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm nice work, in the future would help to also include your testing done in the pr description
Proposed changes
This change updates our build pipeline to build our UBI based images
Closes #3914
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.