Skip to content

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Update READMEs and Makefiles to provide instructions for running the conformance tests on OpenShift clusters, and easy targets for same

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested a review from a team as a code owner October 1, 2025 17:45
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Oct 1, 2025
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had a few comments around documentation but overall looks good

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits for formatting otherwise looks great

@ciarams87 ciarams87 force-pushed the feat/openshift-support branch from 0189049 to 9a4d4f7 Compare October 2, 2025 08:06
ciarams87 and others added 9 commits October 2, 2025 09:10
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
@ciarams87 ciarams87 force-pushed the docs/update-os-conf branch from 5052144 to 7890f9b Compare October 2, 2025 08:13
@ciarams87 ciarams87 force-pushed the docs/update-os-conf branch from 7890f9b to ff8f6d3 Compare October 2, 2025 08:14
@ciarams87 ciarams87 mentioned this pull request Oct 2, 2025
6 tasks
@ciarams87 ciarams87 merged commit 4504014 into feat/openshift-support Oct 2, 2025
91 of 92 checks passed
@ciarams87 ciarams87 deleted the docs/update-os-conf branch October 2, 2025 10:06
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.82%. Comparing base (9a4d4f7) to head (ff8f6d3).
⚠️ Report is 1 commits behind head on feat/openshift-support.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/openshift-support    #3989      +/-   ##
==========================================================
- Coverage                   86.83%   86.82%   -0.01%     
==========================================================
  Files                         128      128              
  Lines                       16607    16607              
  Branches                       62       62              
==========================================================
- Hits                        14420    14419       -1     
- Misses                       2005     2006       +1     
  Partials                      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ciarams87 added a commit that referenced this pull request Oct 2, 2025
Update READMEs and Makefiles to provide instructions for running the conformance tests on OpenShift clusters, and easy targets for same
ciarams87 added a commit that referenced this pull request Oct 2, 2025
Update READMEs and Makefiles to provide instructions for running the conformance tests on OpenShift clusters, and easy targets for same
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants