-
Notifications
You must be signed in to change notification settings - Fork 137
Update readmes and makefiles #3989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just had a few comments around documentation but overall looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits for formatting otherwise looks great
0189049
to
9a4d4f7
Compare
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
Co-authored-by: Saloni Choudhary <146118978+salonichf5@users.noreply.github.com>
5052144
to
7890f9b
Compare
7890f9b
to
ff8f6d3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/openshift-support #3989 +/- ##
==========================================================
- Coverage 86.83% 86.82% -0.01%
==========================================================
Files 128 128
Lines 16607 16607
Branches 62 62
==========================================================
- Hits 14420 14419 -1
- Misses 2005 2006 +1
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update READMEs and Makefiles to provide instructions for running the conformance tests on OpenShift clusters, and easy targets for same
Update READMEs and Makefiles to provide instructions for running the conformance tests on OpenShift clusters, and easy targets for same
Proposed changes
Update READMEs and Makefiles to provide instructions for running the conformance tests on OpenShift clusters, and easy targets for same
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.