Skip to content

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Problem: The conformance and functional tests are failing to use the cache for the Plus UBI images in main causing the builds to fail

Solution: Add the plus secrets to these steps

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner October 6, 2025 12:19
@github-actions github-actions bot added the bug Something isn't working label Oct 6, 2025
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.83%. Comparing base (20d3910) to head (93733e7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4020   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files         128      128           
  Lines       16607    16607           
  Branches       62       62           
=======================================
  Hits        14420    14420           
  Misses       2005     2005           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 force-pushed the fix/add-plus-secrets-tests branch from 04b7ee7 to 93733e7 Compare October 6, 2025 13:00
@ciarams87 ciarams87 merged commit 6e22e50 into main Oct 6, 2025
61 checks passed
@ciarams87 ciarams87 deleted the fix/add-plus-secrets-tests branch October 6, 2025 16:03
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants