Skip to content

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Oct 6, 2025

Proposed changes

Current edge-ubi image for NGF do not pass pre-flight checked due to missing labels and license files:

{
    "name": "HasLicense",
    "elapsed_time": 0,
    "description": "Checking if terms and conditions applicable to the software including open source licensing information are present. The license must be at /licenses",
    "help": "Check HasLicense encountered an error. Please review the preflight.log file for more information.",
    "suggestion": "Create a directory named /licenses and include all relevant licensing and/or terms and conditions as text file(s) in that directory.",
    "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
    "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
},
{
    "name": "HasNoProhibitedLabels",
    "elapsed_time": 0,
    "description": "Checking if the labels (name, vendor, maintainer) violate Red Hat trademark.",
    "help": "Check HasNoProhibitedLabelsCheck encountered an error. Please review the preflight.log file for more information.",
    "suggestion": "Ensure the name, vendor, and maintainer label on your image do not violate the Red Hat trademark.",
    "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
    "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
}

Current edge image for our Operator do not pass pre-flight checked due to missing maintainer labels

"failed": [
          {
              "name": "HasNoProhibitedLabels",
              "elapsed_time": 0,
              "description": "Checking if the labels (name, vendor, maintainer) violate Red Hat trademark.",
              "help": "Check HasNoProhibitedLabelsCheck encountered an error. Please review the preflight.log file for more information.",
              "suggestion": "Ensure the name, vendor, and maintainer label on your image do not violate the Red Hat trademark.",
              "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
              "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
          }
      ],

This change adds these to the Dockerfile

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@shaun-nx shaun-nx requested a review from a team as a code owner October 6, 2025 12:35
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 6, 2025
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.80%. Comparing base (6e22e50) to head (faec461).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
- Coverage   86.81%   86.80%   -0.02%     
==========================================
  Files         128      128              
  Lines       16607    16607              
  Branches       62       62              
==========================================
- Hits        14417    14415       -2     
- Misses       2008     2009       +1     
- Partials      182      183       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shaun-nx shaun-nx added the docker Pull requests that update Docker code label Oct 6, 2025
@shaun-nx shaun-nx merged commit 7af7901 into main Oct 6, 2025
61 checks passed
@shaun-nx shaun-nx deleted the chore/ubi-labels-and-license branch October 6, 2025 16:49
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks docker Pull requests that update Docker code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants