Skip to content

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Oct 7, 2025

Proposed changes

Problem: The operator image name is specified incorrectly in the bundle, and we are missing an annotation required for OpenShift certification

Solution: Fix the image reference and add the missing annotation

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner October 7, 2025 08:27
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Oct 7, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.84%. Comparing base (cb31ea4) to head (395dd1a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4026      +/-   ##
==========================================
+ Coverage   86.83%   86.84%   +0.01%     
==========================================
  Files         128      128              
  Lines       16607    16607              
  Branches       62       62              
==========================================
+ Hits        14421    14423       +2     
+ Misses       2004     2003       -1     
+ Partials      182      181       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 removed the documentation Improvements or additions to documentation label Oct 7, 2025
@ciarams87 ciarams87 changed the title Update operator controller name to include operator Update operator controller name & add annotation Oct 7, 2025
@ciarams87 ciarams87 merged commit f133cfb into main Oct 7, 2025
61 checks passed
@ciarams87 ciarams87 deleted the fix/operator-controller-name branch October 7, 2025 15:58
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants