Skip to content

Conversation

dekobon
Copy link
Collaborator

@dekobon dekobon commented Sep 4, 2025

Fixes #127

This change hardcodes the path to bash when it is used within Docker. Ideally, we should be able to use env to locate bash, it seems that some container execution platforms do not support it.

Invoking bash from the development, CI, or Ubuntu full installs will continue to use the env pattern.

This change builds off of this PR.

Proposed changes

  • Updated the shebang line in common/docker-entrypoint.d/00-check-for-required-env.sh from #!/usr/bin/env bash to #!/usr/bin/bash for consistency and direct interpreter invocation.
  • Updated the shebang line in common/docker-entrypoint.sh from #!/usr/bin/env bash to #!/usr/bin/bash.
  • Added a shebang line (#!/usr/bin/bash) to common/docker-entrypoint.d/22-enable_js_fetch_trusted_certificate.sh to ensure the script is executed with the correct shell.the supported keywords in this PR description (not in the title of the PR).

Checklist

Before creating a pull request (PR), run through this checklist and mark each as complete:

This change hardcodes the path to `bash` when it is used within Docker.
Ideally, we should be able to use `env` to locate `bash`, it seems
that some container execution platforms do not support it.

Invoking `bash` from the development, CI, or Ubuntu full installs will
continue to use the `env` pattern.

Signed-off-by: Elijah Zupancic <e.zupancic@f5.com>
Co-authored-by: ajimenez <ajimenez@lendingpoint.com>
@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 17:29
@dekobon dekobon requested a review from a team as a code owner September 4, 2025 17:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where Docker containers cannot locate bash using the env command by hardcoding the bash path in shebang lines. The change ensures consistent bash interpreter invocation across Docker-specific scripts while maintaining the env pattern for development and CI environments.

  • Updates shebang lines from #!/usr/bin/env bash to #!/usr/bin/bash in Docker entrypoint scripts
  • Adds missing shebang line to one script that previously lacked proper shell specification
  • Maintains compatibility with container execution platforms that don't support env command

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
common/docker-entrypoint.sh Updated shebang to use direct bash path
common/docker-entrypoint.d/00-check-for-required-env.sh Updated shebang to use direct bash path
common/docker-entrypoint.d/22-enable_js_fetch_trusted_certificate.sh Added missing shebang with direct bash path

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dekobon dekobon changed the title Fixes #127 fix: fixes env compatibility problem with container execution Sep 4, 2025
@dekobon dekobon requested a review from 4141done September 4, 2025 17:39
Copy link
Collaborator

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐳

@dekobon dekobon merged commit dce366a into main Sep 4, 2025
10 of 11 checks passed
@dekobon dekobon deleted the fix-127 branch September 4, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants