-
Notifications
You must be signed in to change notification settings - Fork 2
Implement unit-tests for the codebase #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrajagopal
wants to merge
17
commits into
main
Choose a base branch
from
mrajagopal-unit-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b28f5db
Issue 40: Unit-test for CRD
mrajagopal b1f649c
Issue 40: Unit-test for CRD
mrajagopal ee263e6
Merge branch 'main' into mrajagopal-unit-tests
mrajagopal 7bb7833
feat: Create unit tests for NIC, NIM, NGF, and NGX
mrajagopal 29de4ac
Merge branch 'main' into mrajagopal-unit-tests
mrajagopal 33dabbd
Chore: Update to reflect changes in return parameters
mrajagopal d53e7ff
chore: replace deprecated routine filepath.HasPrefix with strings.Has…
mrajagopal 2d9225d
Update pkg/jobs/ngf_job_list_test.go
mrajagopal ecb3c62
Update pkg/jobs/ngf_job_list_test.go
mrajagopal 6d7b09d
Update pkg/data_collector/data_collector.go
mrajagopal 6ef2f3e
Update pkg/jobs/nic_job_list_test.go
mrajagopal e124a26
Update pkg/jobs/job_test.go
mrajagopal 1922e67
Update pkg/jobs/nic_job_list_test.go
mrajagopal 2c2bd5c
Update pkg/jobs/common_job_list_test.go
mrajagopal 3170f31
Fix: Address issues from common_job_list tests
mrajagopal d954b2e
Fix: Implement a mock data_collector
mrajagopal 5e2bd87
Fix: Use the mock data_collector in various tests
mrajagopal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| package crds | ||
|
|
||
| import ( | ||
| "reflect" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestGetNICCRDList(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| want []Crd | ||
| }{ | ||
| { | ||
| name: "Correct CRD list", | ||
| want: []Crd{ | ||
| { | ||
| Resource: "apdoslogconfs", | ||
| Group: "appprotectdos.f5.com", | ||
| Version: "v1beta1", | ||
| }, | ||
| { | ||
| Resource: "apdospolicies", | ||
| Group: "appprotectdos.f5.com", | ||
| Version: "v1beta1", | ||
| }, | ||
| { | ||
| Resource: "dosprotectedresources", | ||
| Group: "appprotectdos.f5.com", | ||
| Version: "v1beta1", | ||
| }, | ||
| { | ||
| Resource: "aplogconfs", | ||
| Group: "appprotect.f5.com", | ||
| Version: "v1beta1", | ||
| }, | ||
| { | ||
| Resource: "appolicies", | ||
| Group: "appprotect.f5.com", | ||
| Version: "v1beta1", | ||
| }, | ||
| { | ||
| Resource: "apusersigs", | ||
| Group: "appprotect.f5.com", | ||
| Version: "v1beta1", | ||
| }, | ||
| { | ||
| Resource: "globalconfigurations", | ||
| Group: "k8s.nginx.org", | ||
| Version: "v1", | ||
| }, | ||
| { | ||
| Resource: "policies", | ||
| Group: "k8s.nginx.org", | ||
| Version: "v1", | ||
| }, | ||
| { | ||
| Resource: "transportservers", | ||
| Group: "k8s.nginx.org", | ||
| Version: "v1", | ||
| }, | ||
| { | ||
| Resource: "virtualserverroutes", | ||
| Group: "k8s.nginx.org", | ||
| Version: "v1", | ||
| }, | ||
| { | ||
| Resource: "virtualservers", | ||
| Group: "k8s.nginx.org", | ||
| Version: "v1", | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| if got := GetNICCRDList(); !reflect.DeepEqual(got, tt.want) { | ||
| t.Errorf("GetNICCRDList() = %v, want %v", got, tt.want) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -36,6 +36,7 @@ import ( | |||||
| "github.com/nginxinc/nginx-k8s-supportpkg/pkg/crds" | ||||||
| "github.com/nginxinc/nginx-k8s-supportpkg/pkg/version" | ||||||
| corev1 "k8s.io/api/core/v1" | ||||||
| apiextensionsclientset "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset" | ||||||
| crdClient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset" | ||||||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||||||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||||||
|
|
@@ -54,12 +55,14 @@ type DataCollector struct { | |||||
| Logger *log.Logger | ||||||
| LogFile *os.File | ||||||
| K8sRestConfig *rest.Config | ||||||
| K8sCoreClientSet *kubernetes.Clientset | ||||||
| K8sCrdClientSet *crdClient.Clientset | ||||||
| K8sMetricsClientSet *metricsClient.Clientset | ||||||
| K8sCoreClientSet kubernetes.Interface | ||||||
|
||||||
| K8sCoreClientSet kubernetes.Interface | |
| K8sCoreClientSet *kubernetes.Clientset |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the type from *kubernetes.Clientset to kubernetes.Interface is a breaking change that could affect existing code that relies on the concrete type. Consider introducing this change in a separate PR or ensure all dependent code is updated accordingly.
Copilot uses AI. Check for mistakes.