Skip to content

fix: eliminate debug log code generation without debug feature in nginx #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

fix: eliminate debug log code generation without debug feature in nginx #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/log.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ use core::ptr::NonNull;

use crate::ffi::{self, ngx_err_t, ngx_log_t, ngx_uint_t, NGX_MAX_ERROR_STR};

/// This constant is set to `true` if NGINX is compiled with debug logging (`--with-debug`).
pub const DEBUG: bool = cfg!(ngx_feature = "debug");

/// Size of the static buffer used to format log messages.
///
/// Approximates the remaining space in `u_char[NGX_MAX_ERROR_STR]` after writing the standard
Expand Down Expand Up @@ -132,7 +135,7 @@ macro_rules! ngx_conf_log_error {
macro_rules! ngx_log_debug {
( mask: $mask:expr, $log:expr, $($arg:tt)+ ) => {
let log = $log;
if $crate::log::check_mask($mask, unsafe { (*log).log_level }) {
if $crate::log::DEBUG && $crate::log::check_mask($mask, unsafe { (*log).log_level }) {
let mut buf =
[const { ::core::mem::MaybeUninit::<u8>::uninit() }; $crate::log::LOG_BUFFER_SIZE];
let message = $crate::log::write_fmt(&mut buf, format_args!($($arg)+));
Expand Down
Loading