[PATCH] Can't build NGINX Unit php module on NetBSD

[osokin]

Hi,

the NGINX Unit's PHP module can't be built on NetBSD 9.0:

cd /pkgsrc/www/unit-php/work/unit-1.20.0 &&  ./configure php --lib-path=/usr/pkg/lib  --module=php5.6.40
configuring PHP module
checking for PHP ... found
 + PHP SAPI: [cli embed cgi]
checking for PHP version ... not found
checking for PHP embed SAPI ... not found

./configure: error: no PHP embed SAPI found.

*** Error code 1

Here's some lines at the end of the build/autoconf.err file:

----------------------------------------
checking for PHP embed SAPI
gcc: Missing argument for -Wl,-rpath
----------

    #include <php.h>
    #include <php_main.h>

    int main() {
        php_module_startup(NULL, NULL, 0);
        return 0;
    }
----------
gcc -O2 -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra
+-Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g -I/usr/pkg/include/php -I/usr/pkg/include/php/main
+-I/usr/pkg/include/php/TSRM -I/usr/pkg/include/php/Zend -I/usr/pkg/include/php/ext -I/usr/pkg/include/php/ext/date/lib -o
+build/autotest build/autotest.c -lphp5 -L/usr/pkg/lib -Wl,-rpath /usr/pkg/lib -L/usr/pkg/lib
[patch-auto-modules-php.txt](https://github.com/nginx/unit/files/5556972/patch-auto-modules-php.txt)

[osokin]

Here's the patch to fix the issue:

--- auto/modules/php.orig       2020-10-09 11:15:55.011861773 -0400
+++ auto/modules/php    2020-10-09 11:16:18.986144628 -0400
@@ -112,7 +112,7 @@
             # "php-config --ldflags" does not contain path to libphp, but
             # contains usually path to libraries required by extensions.
             NXT_PHP_LDFLAGS="-L${NXT_PHP_LIB_PATH} \
-                             -Wl,-rpath ${NXT_PHP_LIB_PATH}"
+                             -Wl,-rpath,${NXT_PHP_LIB_PATH}"
         fi
     fi
 

[VBart]

It's already fixed in 84136eb.