Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Conversation

andypost
Copy link
Contributor

Proposed changes

Since PHP 8.5.0 RC1 the structure been updated #1660

Checklist

Before creating a PR, run through this checklist and mark each as complete:

Closes: nginx#1660
[ Commit message tweak - Andrew ]
Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
@ac000
Copy link
Member

ac000 commented Sep 25, 2025

Ugh, do PHP often make breaking changes this close to release!?

But, yeah, looks good, thanks.

Btw you may or may not have noticed that the Unit project status
recently switched to "Unsupported". However I do intend to review and
merge such changes as this in my spare time, just don't expect a new
release any time soon...

@ac000 ac000 self-requested a review September 25, 2025 03:33
@ac000
Copy link
Member

ac000 commented Sep 25, 2025

Commit message tweak

$ git range-diff b57fb150...ad736f9f
1:  b57fb150 ! 1:  ad736f9f PHP 8.5 new SAPI callback pre_request_init
    @@ Metadata
     Author: Andy Postnikov <apostnikov@gmail.com>
     
      ## Commit message ##
    -    PHP 8.5 new SAPI callback pre_request_init
    +    php: Add a new to 8.5 SAPI callback, pre_request_init
    +
    +    Closes: https://github.com/nginx/unit/issues/1660
    +    [ Commit message tweak - Andrew ]
    +    Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
     
      ## src/nxt_php_sapi.c ##
     @@ src/nxt_php_sapi.c: static sapi_module_struct  nxt_php_sapi_module =

@ac000 ac000 merged commit ad736f9 into nginx:master Sep 25, 2025
24 checks passed
@andypost andypost deleted the 1660-php85-rc1 branch September 25, 2025 17:31
@andypost
Copy link
Contributor Author

thank you, hope after RC new API is stable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants