Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded dependencies to fit with Angular 2 Final #8

Closed
wants to merge 8 commits into from
Closed

upgraded dependencies to fit with Angular 2 Final #8

wants to merge 8 commits into from

Conversation

mzellho
Copy link

@mzellho mzellho commented Sep 14, 2016

rxjs-dependencies are in conflict with the new Angular 2 RC7 as stated in #7

@mzellho
Copy link
Author

mzellho commented Sep 14, 2016

Tests are working fine on my machine running npm test (see below).
Any idea, what's the problem here?

14 09 2016 07:41:13.286:INFO [karma]: Karma v0.13.22 server started at http://localhost:9018/
14 09 2016 07:41:13.302:INFO [launcher]: Starting browser Chrome
14 09 2016 07:41:15.172:INFO [Chrome 52.0.2743 (Windows 10 0.0.0)]: Connected on socket /#pifazoKAZTVO-u4AAAAA with id 54778964
  SyncSubject
    √ should extend Subject
    √ should start with an initialization value
    √ should pump values to multiple subscribers
    √ should clean out unsubscribed subscribers
    √ should be an Observer which can be given to Observable.subscribe
  compose Function
    √ should return an identity function if no functions are composed
    √ should return the result of the first function if only one function is provided
    √ should compose all functions from right to left maintaining the type signature
  enterZone Operator
    √ should cause an observable stream to enter the ng zone
  Router
    √ should compile
  leaveZone Operator
    √ should cause an observable stream to leave the ng zone
  select Operator
    √ should accept a string and return that property from the object
    √ should return a list of strings and deeply map into the object
    √ should accept a map function instead of a string
    √ should not emit a new value if there is no change

Finished in 0.042 secs / 0.014 secs

SUMMARY:
√ 15 tests completed

=============================== Coverage summary ===============================
Statements   : 99.06% ( 105/106 )
Branches     : 74.07% ( 20/27 )
Functions    : 100% ( 28/28 )
Lines        : 98.94% ( 93/94 )
================================================================================

@mzellho mzellho changed the title upgraded rxjs dependencies to ^5.0.0-beta.12 upgraded dependencies to fit with Angular 2 Final Sep 15, 2016
@brandonroberts
Copy link
Member

PR is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants