fix(store): ignore Ivy in runtime checks (#2491)

Closes #2404

Author: timdeschryver

modules/store/spec/meta-reducers/immutability_reducer.spec.ts

@@ -33,6 +33,20 @@ describe('immutabilityCheckMetaReducer:', () => {
       }).toThrow();
     });
 
+    it('should not throw on ivy properties (because these are ignored)', () => {
+      let dispatchedAction: any;
+      expect(() =>
+        invokeActionReducer((state: any, action: any) => {
+          dispatchedAction = action;
+          return state;
+        })
+      ).not.toThrow();
+
+      expect(() => {
+        dispatchedAction.ɵIvyProperty.value = 2;
+      }).not.toThrow();
+    });
+
     it('should not throw when check is off', () => {
       expect(() =>
         invokeActionReducer((state: any, action: any) => {
@@ -46,7 +60,15 @@ describe('immutabilityCheckMetaReducer:', () => {
       immutabilityCheckMetaReducer((state, action) => reduce(state, action), {
         action: () => checkIsOn,
         state: () => false,
-      })({}, { type: 'invoke', numbers: [1, 2, 3], fun: function() {} });
+      })(
+        {},
+        {
+          type: 'invoke',
+          numbers: [1, 2, 3],
+          fun: function() {},
+          ɵIvyProperty: { value: 1 },
+        }
+      );
     }
   });
 

modules/store/spec/meta-reducers/serialization_reducer.spec.ts

@@ -1,6 +1,10 @@
+import { Component } from '@angular/core';
 import { serializationCheckMetaReducer } from '../../src/meta-reducers';
 
 describe('serializationCheckMetaReducer:', () => {
+  class AComponent {}
+  Object.defineProperty(AComponent, 'ɵcmp', {});
+
   const serializables: Record<string, any> = {
     number: { value: 4 },
     boolean: { value: true },
@@ -10,6 +14,7 @@ describe('serializationCheckMetaReducer:', () => {
     nested: { value: { number: 7, array: ['n', 'g', 'r', 'x'] } },
     null: { value: null },
     undefined: { value: undefined },
+    component: AComponent, // components should not throw (because these are ignored)
   };
 
   const unSerializables: Record<string, any> = {

modules/store/src/meta-reducers/immutability_reducer.ts

@@ -20,6 +20,11 @@ function freeze(target: any) {
   const targetIsFunction = isFunction(target);
 
   Object.getOwnPropertyNames(target).forEach(prop => {
+    // Ignore Ivy properties, ref: https://github.com/ngrx/platform/issues/2109#issuecomment-582689060
+    if (prop.startsWith('ɵ')) {
+      return;
+    }
+
     if (
       hasOwnProperty(target, prop) &&
       (targetIsFunction

modules/store/src/meta-reducers/serialization_reducer.ts

@@ -8,6 +8,7 @@ import {
   isString,
   isArray,
   RUNTIME_CHECK_URL,
+  isComponent,
 } from './utils';
 
 export function serializationCheckMetaReducer(
@@ -51,6 +52,11 @@ function getUnserializable(
 
     const value = (target as any)[key];
 
+    // Ignore Ivy components
+    if (isComponent(value)) {
+      return result;
+    }
+
     if (
       isUndefined(value) ||
       isNull(value) ||

modules/store/src/meta-reducers/utils.ts

@@ -46,6 +46,10 @@ export function isFunction(target: any): target is Function {
   return typeof target === 'function';
 }
 
+export function isComponent(target: any) {
+  return isFunction(target) && target.hasOwnProperty('ɵcmp');
+}
+
 export function hasOwnProperty(target: object, propertyName: string): boolean {
   return Object.prototype.hasOwnProperty.call(target, propertyName);
 }