chore: update ESLint dependencies to v20 (#4946)

Author: timdeschryver

modules/component-store/eslint.config.mjs

@@ -11,7 +11,7 @@ const compat = new FlatCompat({
 
 export default [
   {
-    ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/test-setup.ts', '**/schematics-core/utility/standalone.ts'],
+    ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/**/*.ts'],
   },
   ...baseConfig,
   ...compat
@@ -30,6 +30,7 @@ export default [
         '@angular-eslint/directive-selector': 'off',
         '@angular-eslint/component-selector': 'off',
         '@angular-eslint/prefer-standalone': 'off',
+        '@angular-eslint/prefer-inject': 'off',
       },
       languageOptions: {
         parserOptions: {

modules/component/eslint.config.mjs

@@ -11,7 +11,7 @@ const compat = new FlatCompat({
 
 export default [
   {
-    ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/test-setup.ts', '**/schematics-core/utility/standalone.ts'],
+    ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/**/*.ts'],
   },
   ...baseConfig,
   ...compat
@@ -31,6 +31,7 @@ export default [
         '@angular-eslint/component-selector': 'off',
         '@angular-eslint/no-input-rename': 'off',
         '@angular-eslint/prefer-standalone': 'off',
+        '@angular-eslint/prefer-inject': 'off',
       },
       languageOptions: {
         parserOptions: {

modules/data/eslint.config.mjs

@@ -11,7 +11,7 @@ const compat = new FlatCompat({
 
 export default [
   {
-    ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/test-setup.ts'],
+    ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/**/*.ts'],
   },
   ...baseConfig,
   ...compat
@@ -32,6 +32,7 @@ export default [
         '@angular-eslint/component-selector': 'off',
         'no-case-declarations': 'off',
         '@angular-eslint/prefer-standalone': 'off',
+        '@angular-eslint/prefer-inject': 'off',
       },
       languageOptions: {
         parserOptions: {
@@ -50,7 +51,4 @@ export default [
         ...config.rules,
       },
     })),
-  {
-    ignores: ['schematics-core'],
-  },
 ];

modules/effects/eslint.config.mjs

@@ -14,7 +14,7 @@ export default [
     ignores: [
       '**/dist',
       '**/jest.config.ts',
-      '**/schematics-core/test-setup.ts',
+      '**/schematics-core/**/*.ts',
     ],
   },
   ...baseConfig,
@@ -35,6 +35,7 @@ export default [
         '@angular-eslint/component-selector': 'off',
         '@angular-eslint/prefer-standalone': 'off',
         '@nx/enforce-module-boundaries': 'off',
+        '@angular-eslint/prefer-inject': 'off',
       },
       languageOptions: {
         parserOptions: {
@@ -74,7 +75,4 @@ export default [
         ...config.rules,
       },
     })),
-  {
-    ignores: ['schematics-core'],
-  },
 ];

modules/entity/eslint.config.mjs

@@ -11,7 +11,7 @@ const compat = new FlatCompat({
 
 export default [
   {
-    ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/test-setup.ts', '**/schematics-core/utility/standalone.ts'],
+    ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/**/*.ts'],
   },
   ...baseConfig,
   ...compat
@@ -30,6 +30,7 @@ export default [
         '@angular-eslint/directive-selector': 'off',
         '@angular-eslint/component-selector': 'off',
         '@angular-eslint/prefer-standalone': 'off',
+        '@angular-eslint/prefer-inject': 'off',
       },
       languageOptions: {
         parserOptions: {
@@ -48,7 +49,4 @@ export default [
         ...config.rules,
       },
     })),
-  {
-    ignores: ['schematics-core'],
-  },
 ];

modules/eslint-plugin/package.json

@@ -42,7 +42,6 @@
   },
   "sideEffects": false,
   "dependencies": {
-    "semver": "^7.3.5",
     "strip-json-comments": "3.1.1"
   },
   "peerDependencies": {

modules/eslint-plugin/scripts/generate-config.ts

@@ -1,23 +1,23 @@
 import { writeFileSync } from 'fs';
 import { join } from 'path';
 import { format, resolveConfig } from 'prettier';
-import type { NgRxRuleModule } from '../src/rule-creator';
 import { rulesForGenerate } from '../src/utils/helper-functions/rules';
+import { NgRxRule } from '../src/rule-creator';
 
 const prettierConfig = resolveConfig.sync(__dirname);
 
 const RULE_MODULE = '@ngrx';
 const CONFIG_DIRECTORY = './modules/eslint-plugin/src/configs/';
 
 writeConfig('all', (_rule) => true);
-writeConfig('store', (rule) => rule.meta.ngrxModule === 'store');
-writeConfig('effects', (rule) => rule.meta.ngrxModule === 'effects');
+writeConfig('store', (rule) => rule.meta.docs?.ngrxModule === 'store');
+writeConfig('effects', (rule) => rule.meta.docs?.ngrxModule === 'effects');
 writeConfig(
   'component-store',
-  (rule) => rule.meta.ngrxModule === 'component-store'
+  (rule) => rule.meta.docs?.ngrxModule === 'component-store'
 );
-writeConfig('operators', (rule) => rule.meta.ngrxModule === 'operators');
-writeConfig('signals', (rule) => rule.meta.ngrxModule === 'signals');
+writeConfig('operators', (rule) => rule.meta.docs?.ngrxModule === 'operators');
+writeConfig('signals', (rule) => rule.meta.docs?.ngrxModule === 'signals');
 
 function writeConfig(
   configName:
@@ -27,7 +27,7 @@ function writeConfig(
     | 'component-store'
     | 'operators'
     | 'signals',
-  predicate: (rule: NgRxRuleModule<[], string>) => boolean
+  predicate: (rule: NgRxRule) => boolean
 ) {
   const rulesForConfig = Object.entries(rulesForGenerate).filter(([_, rule]) =>
     predicate(rule)

modules/eslint-plugin/scripts/generate-docs.ts

@@ -23,8 +23,6 @@ for (const rules of RULES_PATHS) {
     const newDoc = format(
       `# ${ruleName}
 
-${meta.version ? '> Required NgRx Version Range: ${meta.version}' : ''}
-
 ${meta.docs?.description}
 
 - **Type**: ${meta.type}

modules/eslint-plugin/scripts/generate-overview.ts

@@ -18,7 +18,11 @@ function generateRules() {
   const moduleRules = Object.entries(rulesForGenerate).reduce<
     Record<string, string[][]>
   >((all, [ruleName, { meta }]) => {
-    all[meta.ngrxModule] = (all[meta.ngrxModule] ?? []).concat([
+    if (!meta.docs) {
+      throw new Error(`Rule ${ruleName} is missing meta.docs information`);
+    }
+
+    all[meta.docs.ngrxModule] = (all[meta.docs.ngrxModule] ?? []).concat([
       [
         `[@ngrx/${ruleName}]${
           meta.docs?.url

modules/eslint-plugin/spec/utils/rule-tester.ts

@@ -1,17 +1,7 @@
-import { clearCache, setNgrxVersion } from '../../src/utils';
 import { RuleTester } from '@typescript-eslint/rule-tester';
 import { resolve } from 'path';
 
-export function ruleTester(environment?: {
-  ngrxModule: string;
-  version: string;
-}) {
-  clearCache();
-
-  if (environment) {
-    setNgrxVersion(environment.ngrxModule, environment.version);
-  }
-
+export function ruleTester() {
   return new RuleTester({
     languageOptions: {
       parserOptions: {