feat(schematics): remove creators option (#3311)

BREAKING CHANGES:

BEFORE:

Creating actions, reducers, and effects is possible without using the creator syntax is possible.

AFTER:

- All schematics use the non-creator syntax to scaffold the code.
- The option `--creators` (and `-c`) is removed from the schematic options.
- The `skipTests` option is removed while generating actions.

Author: timdeschryver

angular.json

@@ -757,12 +757,6 @@
               {
                 "command": "cpy modules/schematics/src/**/files/**/*.* dist/ --parents"
               },
-              {
-                "command": "cpy modules/schematics/src/**/creator-files/**/*.* dist/ --parents"
-              },
-              {
-                "command": "cpy modules/schematics/src/**/common-files/**/*.* dist/ --parents"
-              },
               {
                 "command": "cpy modules/schematics/src/**/integration-files/**/*.* dist/ --parents"
               },

modules/component-store/schematics-core/utility/ngrx-utils.ts

@@ -269,8 +269,6 @@ export function omit<T extends { [key: string]: any }>(
     .reduce((result, key) => Object.assign(result, { [key]: object[key] }), {});
 }
 
-export function getPrefix(options: { prefix?: string; creators?: boolean }) {
-  return options.creators
-    ? stringUtils.camelize(options.prefix || 'load')
-    : stringUtils.capitalize(options.prefix || 'load');
+export function getPrefix(options: { prefix?: string }) {
+  return stringUtils.camelize(options.prefix || 'load');
 }

modules/component/schematics-core/utility/ngrx-utils.ts

@@ -269,8 +269,6 @@ export function omit<T extends { [key: string]: any }>(
     .reduce((result, key) => Object.assign(result, { [key]: object[key] }), {});
 }
 
-export function getPrefix(options: { prefix?: string; creators?: boolean }) {
-  return options.creators
-    ? stringUtils.camelize(options.prefix || 'load')
-    : stringUtils.capitalize(options.prefix || 'load');
+export function getPrefix(options: { prefix?: string }) {
+  return stringUtils.camelize(options.prefix || 'load');
 }

modules/data/schematics-core/utility/ngrx-utils.ts

@@ -269,8 +269,6 @@ export function omit<T extends { [key: string]: any }>(
     .reduce((result, key) => Object.assign(result, { [key]: object[key] }), {});
 }
 
-export function getPrefix(options: { prefix?: string; creators?: boolean }) {
-  return options.creators
-    ? stringUtils.camelize(options.prefix || 'load')
-    : stringUtils.capitalize(options.prefix || 'load');
+export function getPrefix(options: { prefix?: string }) {
+  return stringUtils.camelize(options.prefix || 'load');
 }

modules/effects/schematics-core/utility/ngrx-utils.ts

@@ -269,8 +269,6 @@ export function omit<T extends { [key: string]: any }>(
     .reduce((result, key) => Object.assign(result, { [key]: object[key] }), {});
 }
 
-export function getPrefix(options: { prefix?: string; creators?: boolean }) {
-  return options.creators
-    ? stringUtils.camelize(options.prefix || 'load')
-    : stringUtils.capitalize(options.prefix || 'load');
+export function getPrefix(options: { prefix?: string }) {
+  return stringUtils.camelize(options.prefix || 'load');
 }

modules/entity/schematics-core/utility/ngrx-utils.ts

@@ -269,8 +269,6 @@ export function omit<T extends { [key: string]: any }>(
     .reduce((result, key) => Object.assign(result, { [key]: object[key] }), {});
 }
 
-export function getPrefix(options: { prefix?: string; creators?: boolean }) {
-  return options.creators
-    ? stringUtils.camelize(options.prefix || 'load')
-    : stringUtils.capitalize(options.prefix || 'load');
+export function getPrefix(options: { prefix?: string }) {
+  return stringUtils.camelize(options.prefix || 'load');
 }

modules/router-store/schematics-core/utility/ngrx-utils.ts

@@ -269,8 +269,6 @@ export function omit<T extends { [key: string]: any }>(
     .reduce((result, key) => Object.assign(result, { [key]: object[key] }), {});
 }
 
-export function getPrefix(options: { prefix?: string; creators?: boolean }) {
-  return options.creators
-    ? stringUtils.camelize(options.prefix || 'load')
-    : stringUtils.capitalize(options.prefix || 'load');
+export function getPrefix(options: { prefix?: string }) {
+  return stringUtils.camelize(options.prefix || 'load');
 }

modules/schematics-core/utility/ngrx-utils.ts

@@ -269,8 +269,6 @@ export function omit<T extends { [key: string]: any }>(
     .reduce((result, key) => Object.assign(result, { [key]: object[key] }), {});
 }
 
-export function getPrefix(options: { prefix?: string; creators?: boolean }) {
-  return options.creators
-    ? stringUtils.camelize(options.prefix || 'load')
-    : stringUtils.capitalize(options.prefix || 'load');
+export function getPrefix(options: { prefix?: string }) {
+  return stringUtils.camelize(options.prefix || 'load');
 }

modules/schematics/schematics-core/utility/ngrx-utils.ts

@@ -269,8 +269,6 @@ export function omit<T extends { [key: string]: any }>(
     .reduce((result, key) => Object.assign(result, { [key]: object[key] }), {});
 }
 
-export function getPrefix(options: { prefix?: string; creators?: boolean }) {
-  return options.creators
-    ? stringUtils.camelize(options.prefix || 'load')
-    : stringUtils.capitalize(options.prefix || 'load');
+export function getPrefix(options: { prefix?: string }) {
+  return stringUtils.camelize(options.prefix || 'load');
 }

modules/schematics/src/action/creator-files/__name@dasherize@if-flat__/__name@dasherize__.actions.spec.ts.template

@@ -1,24 +1,15 @@
-import { Action } from '@ngrx/store';
+import { createAction, props } from '@ngrx/store';
 
-export enum <%= classify(name) %>ActionTypes {
-  <%= prefix %><%= classify(name) %>s = '[<%= classify(name) %>] <%= prefix %> <%= classify(name) %>s',
-  <% if (api) { %><%= prefix %><%= classify(name) %>sSuccess = '[<%= classify(name) %>] <%= prefix %> <%= classify(name) %>s Success',<% } %>
-  <% if (api) { %><%= prefix %><%= classify(name) %>sFailure = '[<%= classify(name) %>] <%= prefix %> <%= classify(name) %>s Failure',<% } %>
-}
+export const <%= prefix %><%= classify(name) %>s = createAction(
+  '[<%= classify(name) %>] <%= classify(prefix) %> <%= classify(name) %>s'
+);
 
-export class <%= prefix %><%= classify(name) %>s implements Action {
-  readonly type = <%= classify(name) %>ActionTypes.<%= prefix %><%= classify(name) %>s;
-}
-<% if (api) { %>
-export class <%= prefix %><%= classify(name) %>sSuccess implements Action {
-  readonly type = <%= classify(name) %>ActionTypes.<%= prefix %><%= classify(name) %>sSuccess;
-  constructor(public payload: { data: any }) { }
-}
+<% if (api) { %>export const <%= prefix %><%= classify(name) %>sSuccess = createAction(
+  '[<%= classify(name) %>] <%= classify(prefix) %> <%= classify(name) %>s Success',
+  props<{ data: any }>()
+);<% } %>
 
-export class <%= prefix %><%= classify(name) %>sFailure implements Action {
-  readonly type = <%= classify(name) %>ActionTypes.<%= prefix %><%= classify(name) %>sFailure;
-  constructor(public payload: { error: any }) { }
-}
-<% } %>
-<% if (api) { %>export type <%= classify(name) %>Actions = <%= prefix %><%= classify(name) %>s | <%= prefix %><%= classify(name) %>sSuccess | <%= prefix %><%= classify(name) %>sFailure;<% } %>
-<% if (!api) { %>export type <%= classify(name) %>Actions = <%= prefix %><%= classify(name) %>s;<% } %>
+<% if (api) { %>export const <%= prefix %><%= classify(name) %>sFailure = createAction(
+  '[<%= classify(name) %>] <%= classify(prefix) %> <%= classify(name) %>s Failure',
+  props<{ error: any }>()
+);<% } %>