fix(eslint-plugin): allow sequential dispatches in a different block …

…context (#3515) Closes #3513
ngrx · Aug 6, 2022 · faf446f · faf446f
1 parent 4642919
commit faf446f
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/modules/eslint-plugin/spec/rules/avoid-dispatching-multiple-actions-sequentially.spec.ts b/modules/eslint-plugin/spec/rules/avoid-dispatching-multiple-actions-sequentially.spec.ts
@@ -62,6 +62,36 @@ ngOnInit() {
     this.store.dispatch(anotherOne());
   });
 }
+}`,
+  // https://github.com/ngrx/platform/issues/3513
+  `
+import { Store } from '@ngrx/store'
+
+class Ok {
+constructor(private store: Store) {}
+
+ngOnInit() {
+  this.store.dispatch(one());
+
+  this.store.subscribe(() => {
+    this.store.dispatch(anotherOne());
+  });
+}
+}`,
+  // https://github.com/ngrx/platform/issues/3513
+  `
+import { Store } from '@ngrx/store'
+
+class Ok {
+constructor(private store: Store) {}
+
+ngOnInit() {
+  this.store.dispatch(anotherOne());
+
+  this.store.subscribe(() => {
+    this.store.dispatch(one());
+  });
+}
 }`,
 ];
 

diff --git a/modules/eslint-plugin/src/rules/store/avoid-dispatching-multiple-actions-sequentially.ts b/modules/eslint-plugin/src/rules/store/avoid-dispatching-multiple-actions-sequentially.ts
@@ -32,25 +32,30 @@ export default createRule<Options, MessageIds>({
       return {};
     }
 
-    const collectedDispatches = new Set<TSESTree.CallExpression>();
+    const collectedDispatches: TSESTree.CallExpression[] = [];
 
     return {
       [`BlockStatement > ExpressionStatement > ${dispatchExpression(
         storeNames
       )}`](node: TSESTree.CallExpression) {
-        collectedDispatches.add(node);
+        collectedDispatches.push(node);
       },
       'BlockStatement:exit'() {
-        if (collectedDispatches.size > 1) {
-          for (const node of collectedDispatches) {
+        const withSameParent = collectedDispatches.filter((d1) =>
+          collectedDispatches.some(
+            (d2) => d2 !== d1 && d2.parent?.parent === d1.parent?.parent
+          )
+        );
+        if (withSameParent.length > 1) {
+          for (const node of withSameParent) {
             context.report({
               node,
               messageId,
             });
           }
         }
 
-        collectedDispatches.clear();
+        collectedDispatches.length = 0;
       },
     };
   },