expose Dictionary as part of an API #1118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When code exports a symbol whose type is inferred (or contains an inferred type), the type must be imported so that a correct name can be generated for it in the resulting .d.ts file.
For example, that means when we create any
selector
we have to importMemoizedSelector
to the file, and, also not to have the unused import linter error, at least one of the selectors has to be fully typed.Since
MemoizedSelector
is exported throughpublic_api.ts
, solving this problem is pretty straightforward, however one of the teams has started usingentities
now and has to importDictionary
for the exactly same reason, butDictionary
is not exported.e.g. this is the code that they need to use:
for more on exported variables with inferred type:
microsoft/TypeScript#5711 (comment)