-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Example): add cypress tests #1565
Conversation
cypress is using an old listr package that is pinned to rxjs 5.x
…_modules" This reverts commit 1de99b5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what do you think about deleting the example-app-e2e
folder? We don't need two e2e test suites.
"example:build:prod": "yarn example:build -- --base-href \"/platform/example-app/\"", | ||
"ci": "yarn run test && nyc report --reporter=text-lcov | coveralls", | ||
"example:server": "node build/example-app-server", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this into the group with the other example:
scripts
Also, is there a way to make this run with Bazel? |
I'm agreeing to remove the existing e2e folder (and the existing config). |
We're blocked on the Bazel part bazelbuild/rules_typescript#261. Once the old config is removed, everything else LGTM |
Preview docs changes for 83c5784 at https://previews.ngrx.io/pr1565-83c5784/ |
.circleci/config.yml
Outdated
@@ -83,10 +83,12 @@ jobs: | |||
- run: yarn run ci | |||
- run: yarn run example:build:prod | |||
- run: yarn run example:test --watch=false | |||
- run: yarn run example:cypress:ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move the example app ones into a separate job and leave this one for unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also moved yarn run example:build:prod
to the separate job, because we need this in order to run the e2e tests 😄
Preview docs changes for 163dc75 at https://previews.ngrx.io/pr1565-163dc75/ |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1556
What is the new behavior?
Does this PR introduce a breaking change?
Other information