Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): circular dep #1833

Merged
merged 1 commit into from
May 7, 2019
Merged

fix(example): circular dep #1833

merged 1 commit into from
May 7, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The #1808 PR introduced a circular dep, and the example-app couldn't be served locally.
Related to #1684

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 7, 2019

Preview docs changes for 388a52b at https://previews.ngrx.io/pr1833-388a52b/

@brandonroberts brandonroberts merged commit 1fbd59c into master May 7, 2019
@brandonroberts brandonroberts deleted the pr/example-cycle-dep branch May 7, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants