feat(signals): add support all providedIn types from Injectable
(#4963)
#4964
+22
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Cannot pass any
providedIn
exceptroot
.Closes #4963
What is the new behavior?
Added support to any not deprecated
providedIn
types.Does this PR introduce a breaking change?
Other information
I was thinking of just adding the
platform
to the union. But it seems that if here we just pass the value into theInjectable
decorator, then we should rely on the typing of this decorator. The only thing seems to be that we should exclude deprecated types from union, so as not to add support for what will be removed soon.