Skip to content

Conversation

MillerSvt
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Cannot pass any providedIn except root.

Closes #4963

What is the new behavior?

Added support to any not deprecated providedIn types.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I was thinking of just adding the platform to the union. But it seems that if here we just pass the value into the Injectable decorator, then we should rely on the typing of this decorator. The only thing seems to be that we should exclude deprecated types from union, so as not to add support for what will be removed soon.

Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 40110c4
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/68e140e33bd4fc0008a2e0a5
😎 Deploy Preview https://deploy-preview-4964--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 40110c4
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/68e140e39a80a50008ff4c93

@MillerSvt MillerSvt force-pushed the add-provided-in-platform branch from d4ee15f to 40110c4 Compare October 4, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support providedIn: 'platform'
2 participants