Add binary capture file parser#396
Merged
azonenberg merged 16 commits intongscopeclient:masterfrom Apr 12, 2021
sam210723:master
Merged
Add binary capture file parser#396azonenberg merged 16 commits intongscopeclient:masterfrom sam210723:master
azonenberg merged 16 commits intongscopeclient:masterfrom
sam210723:master
Conversation
Parser for Agilent/Keysight/Rigol binary capture files
miek
reviewed
Feb 26, 2021
Contributor
Author
|
Leaks everywhere, I should learn proper memory management. Thanks for having a look, I'll fix those up soon. |
bvernoux
reviewed
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a parser for Agilent, Keysight and Rigol multi-channel binary waveform capture files.
I've added helper functions
ReadFromFile(),BytesToInt(),BytesToFloat()andBytesToDouble()to make parsing the file headers easier. I don't write C++ code all that often so let me know if there's a better way to do this.See related PR ngscopeclient/scopehal-apps#307 for changes to Import dialog.