-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage-plugin): require only getItem
and setItem
on engines
#2036
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4e667b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
This commit updates the signature of the `StorageEngine` interface and removes unnecessary properties that are not being used by the storage plugin. The properties `length`, `removeItem`, and `clear` have been removed. This change makes it easier to maintain storage engines that implement the interface because only the necessary properties will be required. It is important to note that this change is not considered a breaking change since properties are being removed rather than added.
daa6abd
to
4e667b1
Compare
BundleMonUnchanged files (3)
No change in files bundle size Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (2)
Unchanged files (12)
Total files change +56B +0.1% Groups updated (3)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (3)
Total files change -54B -0.03% Final result: ✅ View report in BundleMon website ➡️ |
Code Climate has analyzed commit 4e667b1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit updates the signature of the
StorageEngine
interfaceand removes unnecessary properties that are not being used by the storage
plugin. The properties
length
,removeItem
, andclear
have been removed.This change makes it easier to maintain storage engines that implement the
interface because only the necessary properties will be required. It is important
to note that this change is not considered a breaking change since properties are
being removed rather than added.