Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update waiting for app stability recipe for Angular 18 #2170

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Jun 7, 2024

In this commit, we updated the "waiting for app stability" recipe to use
the experimental pending tasks service, which was publicly exposed in the
Angular API starting from version 18.

Copy link

nx-cloud bot commented Jun 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f1f9245. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Jun 7, 2024

BundleMon (Integration Projects)

Unchanged files (2)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
68.5KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
67.03KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codeclimate bot commented Jun 7, 2024

Code Climate has analyzed commit c1add5c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.5% (0.0% change).

View more on Code Climate.

@markwhitfeld markwhitfeld changed the title docs: update waiting for app stability recipe docs: update waiting for app stability recipe for Angular 18 Jun 7, 2024
In this commit, we updated the "waiting for app stability" recipe to use
the experimental pending tasks service, which was publicly exposed in the
Angular API starting from version 18.
@arturovt arturovt merged commit 40cb2e6 into master Jun 7, 2024
2 of 4 checks passed
@arturovt arturovt deleted the docs/update-pending-tasks branch June 7, 2024 12:43
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants