feat(store): implement iif operator #778
Conversation
|
codeclimate whines about missing semicolon, if i add this semicolon - prettier anyway removes it :D |
packages/store/operators/src/iif.ts
Outdated
| const operatorAndExistingNotProvided = !isStateOperator(operatorOrValue) && !existing; | ||
| if (operatorAndExistingNotProvided) { | ||
| return operatorOrValue as T; | ||
| } |
There was a problem hiding this comment.
I suspect that you could leave out these 4 lines of code above and it would all still work perfectly ;-)
packages/store/operators/src/iif.ts
Outdated
| return function iifOperator(existing: Readonly<T>): T { | ||
| // If condition is not `null` and not `undefined` | ||
| let result = !!condition; | ||
| // If condition is a function |
There was a problem hiding this comment.
// Convert the value to a boolean
let result = !!condition;
// but if it is a function then run it to get the result
|
|
||
| export type PatchValues<T> = { | ||
| readonly [P in keyof T]?: T[P] extends (...args: any[]) => infer R ? R : T[P] | ||
| }; |
There was a problem hiding this comment.
I see the idea with moving these into a shared file but I can't see any case where they would be used by other operators so I think that they should move back to their respective operator files. Just keep the operators code together nicely.
| return typeof value === 'undefined'; | ||
| } | ||
|
|
||
| export function isPredicate<T>(value: Predicate<T> | boolean): value is Predicate<T> { |
There was a problem hiding this comment.
This could move back into the iif.ts file for now, nothing else uses it.
| export function isStateOperator<T>(value: T | StateOperator<T>): value is StateOperator<T> { | ||
| return typeof value === 'function'; | ||
| } | ||
|
|
||
| export function isUndefined(value: unknown): value is undefined { |
There was a problem hiding this comment.
Isn't this function provided by typescript in its' standard lib?
There was a problem hiding this comment.
@markwhitfeld unfortunately :(
| }); | ||
| }); | ||
|
|
||
| describe('when undefined provided', () => { |
There was a problem hiding this comment.
| describe('when undefined provided', () => { | |
| describe('when undefined condition provided', () => { |
| import { patch } from '../src/patch'; | ||
|
|
||
| describe('iif', () => { | ||
| describe('when null provided', () => { |
There was a problem hiding this comment.
| describe('when null provided', () => { | |
| describe('when null condition provided', () => { |
| expect(newValue).toBe(original); | ||
| }); | ||
|
|
||
| it('returns the same root if "else" condition is provided', () => { |
There was a problem hiding this comment.
| it('returns the same root if "else" condition is provided', () => { | |
| it('returns the same root if "else" provides same value as existing', () => { |
| expect(newValue).toBe(original); | ||
| }); | ||
|
|
||
| it('returns patched object if "else" condition is provided', () => { |
There was a problem hiding this comment.
| it('returns patched object if "else" condition is provided', () => { | |
| it('returns patched object if "else" is provided with a new value', () => { |
| expect(newValue).toBe(original); | ||
| }); | ||
|
|
||
| it('returns the same root if "else" value provided', () => { |
There was a problem hiding this comment.
| it('returns the same root if "else" value provided', () => { | |
| it('returns the same root if "else" provides same value as existing', () => { |
|
@markwhitfeld ping 🚀 |
PR Checklist
PR Type
What is the current behavior?
Issue Number: #545
What is the new behavior?
Does this PR introduce a breaking change?