NH-2821 - better way of finding log4net #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See discussion in linked JIRA issue. |
|
@whut Thanks for providing a potential fix for this. However, the matter was discussed again in the mailing list, and the general consensus is that logging should require explicit configuration. For backwards compatibility, putting log4net in the deploy directory can be regarded as explicit configuration, while putting it in the GAC is not. http://groups.google.com/group/nhibernate-development/browse_thread/thread/b2abdfafc50148fb I'm closing this pull request now. A different solution would be to split the RelativeSearchPath on semicolon and check each directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addded fix for log4net not always finding, reported in https://nhibernate.jira.com/browse/NH-2821