Skip to content

Conversation

rjperes
Copy link
Member

@rjperes rjperes commented Aug 13, 2014

http://nhibernate.jira.com/browse/NH-2920

Includes Microsoft.Data.Services.dll from WCF Data Services 5.6 (http://www.microsoft.com/en-us/download/details.aspx?id=39373)

@hazzik
Copy link
Member

hazzik commented Aug 13, 2014

Build is failing on teamcity. Also there is unnecessary witespace changes

@rjperes
Copy link
Member Author

rjperes commented Aug 13, 2014

Fixed. The problem was in NHibernate.TestDatabaseSetup.
As for the whitespaces, that was because the .build file was using UNIX line endings.

@hazzik hazzik mentioned this pull request Aug 13, 2014
@oskarb
Copy link
Member

oskarb commented Aug 17, 2014

Can we have tests for this? A test case should be able to set up a ServiceHost and call it, right?

@hazzik
Copy link
Member

hazzik commented Aug 17, 2014

I do not want to have this extra dependency. It should defenetely be a separate library.

@hazzik
Copy link
Member

hazzik commented Aug 17, 2014

Also, the build is failing

@rjperes
Copy link
Member Author

rjperes commented Aug 17, 2014

Alex:
I understand, but the only candidate "separate library" is NHCommons, and we all know that it is semi-dead, even if it was discussed recently to revive it. This reference is only needed if someone is to implement a WCF Data Service and the NuGet package already adds it.
Oskar:
It is possible to unit test, yes. If we decide to keep this, I can provide them.

@hazzik
Copy link
Member

hazzik commented Aug 18, 2014

@rjperes, I do not like the idea of "commons" or "contrib"-like approaches. I'm talking about separate library "NHibernate.DataServices"

@hazzik hazzik added this to the 5.0.0 milestone Sep 21, 2014
@hazzik hazzik changed the title NH-2920 NH-2920 - Linq: NHibernateContext for WCF Data Service Dec 2, 2014
@hazzik hazzik changed the title NH-2920 - Linq: NHibernateContext for WCF Data Service NH-2920 - NHibernateContext for WCF Data Service Dec 2, 2014
@hazzik
Copy link
Member

hazzik commented Dec 2, 2014

Probably this should be contributed to https://github.com/pvginkel/NHibernate.OData /cc @pvginkel

@hazzik
Copy link
Member

hazzik commented Apr 6, 2017

Closed as per JIRA.

@hazzik hazzik removed this from the 5.0.0 milestone Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants