Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Linq Joiner class removing no longer needed AddJoinMethod property #3391

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Clean up Linq Joiner class removing no longer needed AddJoinMethod property #3391

merged 2 commits into from
Aug 2, 2023

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Aug 1, 2023 •
edited
Loading

Obsoleted by #2539

@fredericDelaporte fredericDelaporte added this to the 5.5 milestone Aug 1, 2023
fredericDelaporte
fredericDelaporte approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be labeled as a t:fix of some other pr?

@bahusoid
Copy link
Member Author

bahusoid commented Aug 1, 2023

Shouldn't it be labeled as a t:fix of some other pr?

Did you mean find PR that made AddJoinMethod not needed. Ok I will check tomorrow.

@bahusoid
Copy link
Member Author

bahusoid commented Aug 1, 2023

Did you mean find PR that made AddJoinMethod not needed

It was obsoleted by #2539

@bahusoid bahusoid merged commit 782f8d7 into nhibernate:master Aug 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@bahusoid @hazzik @fredericDelaporte