-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: protect ops endpoints requiring admin (#122)
* fix: protect ops endpoints requiring admin
- Loading branch information
Showing
4 changed files
with
123 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package auth | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "strings" | ||
|
|
||
| "github.com/gin-gonic/gin" | ||
| ) | ||
|
|
||
| func isAdmin(hasuraAdminSecret string, header http.Header) bool { | ||
| return header.Get("X-Hasura-Admin-Secret") == hasuraAdminSecret && | ||
| (header.Get("X-Hasura-Role") == "admin" || | ||
| header.Get("X-Hasura-Role") == "") | ||
| } | ||
|
|
||
| func NeedsAdmin(prefixPath, hasuraAdminSecret string) gin.HandlerFunc { | ||
| return func(ctx *gin.Context) { | ||
| if strings.HasPrefix(ctx.Request.URL.Path, prefixPath) && | ||
| !isAdmin(hasuraAdminSecret, ctx.Request.Header) { | ||
| ctx.AbortWithStatus(http.StatusUnauthorized) | ||
| return | ||
| } | ||
| ctx.Next() | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| package auth //nolint: testpackage | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestIsAdmin(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| cases := []struct { | ||
| name string | ||
| reqHeader http.Header | ||
| isAdmin bool | ||
| }{ | ||
| { | ||
| name: "correct secret and empty role", | ||
| reqHeader: http.Header{ | ||
| "X-Hasura-Admin-Secret": []string{"secret"}, | ||
| }, | ||
| isAdmin: true, | ||
| }, | ||
| { | ||
| name: "correct secret and role", | ||
| reqHeader: http.Header{ | ||
| "X-Hasura-Admin-Secret": []string{"secret"}, | ||
| "X-Hasura-Role": []string{"admin"}, | ||
| }, | ||
| isAdmin: true, | ||
| }, | ||
| { | ||
| name: "correct secret and wrong role", | ||
| reqHeader: http.Header{ | ||
| "X-Hasura-Admin-Secret": []string{"secret"}, | ||
| "X-Hasura-Role": []string{"user"}, | ||
| }, | ||
| isAdmin: false, | ||
| }, | ||
| { | ||
| name: "wrong secret and correct role", | ||
| reqHeader: http.Header{ | ||
| "X-Hasura-Admin-Secret": []string{"woooo"}, | ||
| "X-Hasura-Role": []string{"admin"}, | ||
| }, | ||
| isAdmin: false, | ||
| }, | ||
| { | ||
| name: "wrong secret and no role", | ||
| reqHeader: http.Header{ | ||
| "X-Hasura-Admin-Secret": []string{"woooo"}, | ||
| }, | ||
| isAdmin: false, | ||
| }, | ||
| { | ||
| name: "no headers", | ||
| reqHeader: http.Header{}, | ||
| isAdmin: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range cases { | ||
| tc := tc | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| tc := tc | ||
|
|
||
| got := isAdmin("secret", tc.reqHeader) | ||
| if got != tc.isAdmin { | ||
| t.Errorf("isAdmin() = %v, want %v", got, tc.isAdmin) | ||
| } | ||
| }) | ||
| } | ||
| } |