feat: added x-hasura-role to allowed headers in CORS #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
x-hasura-role
to the list of allowed headers for CORS.Problem
For web requests made in single-page applications using a JWT with a desired role other than that specified in
x-hasura-default-role
: specifying the header with value'X-Hasura-Role': 'desired-role'
is required to transact. Without this header in the allowed list for CORS, the preflight check made in the browser will fail the transaction.Solution
Added "x-hasura-role" to the list of allowed headers.
Notes
To test this:
Generate a jwt with a default permission other than admin as the default
Then allow permissions for the role being tested in the hasura
storage_files
table using the web consoleThen make a single page web app using the development stack
npm install
thennpm run dev
to run the appmyapp/src/lib/Counter.svelte
to use a role with insert permissionsCloses #119