-
Notifications
You must be signed in to change notification settings - Fork 11
Update javascript-styleguide packages to be compatible with eslint v9 #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rajsite
merged 53 commits into
main
from
users/gokulprasanthRavi/feat/update-packages-to-eslint-v9-version
Oct 1, 2025
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
7f34462
feat: update packages to eslint v9
ff13028
fix: issues
96e9cab
fix: test issue
37d0807
update angular-eslint version
dfbed78
update to type module
0168590
Change files
382bacb
update readme doc
4e18ae7
update change file email
7a2a8c7
update as per pr comments
d830fa3
update angular-eslint version
e52cb9d
remove no-undef eslint comment
ca9199c
fix: import resolver issue
df5b22c
address lvl 1 PR comments
56edf11
address lvl2 pr comments
c1a09a2
Replace spread with export
a110ff5
handle rules based on comments
e278153
update print evaluated rules
7196ed5
update print evaluated rules code
1333caf
refactor: update package with named exports
b7f4d3c
update readme info
be994ea
add flat config migration section in readme
d6a557c
enable strict null checks by default
0d197d5
add comments to the newly added rules in the project's eslint.config.js
706ae3d
Fix: issue
8d01013
Fix 'import/no-extraneous-dependencies': 'off'
jattasNI f22f19f
no-unresolved
jattasNI 303f23f
Re-add test from typechecking
jattasNI 90d243e
strictNullChecks
jattasNI f6c6754
Fix test failure
jattasNI f50f631
README formatting
jattasNI 1de9e26
clean up
c549133
address PR comments
22c786f
update moduleResolution to node16
c79ce9c
address lvl2 PR comments
5132f42
remove unwanted rules
c48ac12
update README file
9693626
update change files
4895a37
update eslint configuration in readme
c4a9645
update rule
d54f552
Update lockfile
rajsite 1d30d17
Use defineConfig, single entrypoint, consistent config import
rajsite 2f954e3
fix import
rajsite cb62b9d
update test config
d033cd7
Dedupe import node esm config
rajsite 0cf436d
Consistent lib layout
rajsite 30d85e0
Update copyright year
rajsite 162905b
Consistent tsconfig files
rajsite 4f90a27
Consistent test eslint config
rajsite 45aa7a4
Align README and test examples
rajsite c65ec53
Update to recent versions
rajsite 33c508d
Rename angularConfig to angularTypescriptConfig
jattasNI f8e2789
Improve changefile message
jattasNI de23ebb
Revert accidental test change
jattasNI File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
7 changes: 7 additions & 0 deletions
7
change/@ni-eslint-config-angular-2b894e10-2f6e-4ff2-ade2-fae0335c38d8.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
gokulprasanth-ni marked this conversation as resolved.
Show resolved
Hide resolved
gokulprasanth-ni marked this conversation as resolved.
Show resolved
Hide resolved
gokulprasanth-ni marked this conversation as resolved.
Show resolved
Hide resolved
rajsite marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"type": "major", | ||
gokulprasanth-ni marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"comment": "Update eslint-config-angular to be compatible with eslint v9. Change default rule configuration to assume `strictNullChecks` is enabled. See [Migration Guide](https://github.com/ni/javascript-styleguide/blob/main/README.md#migrating-to-eslint-flat-configuration-format) for more information.", | ||
"packageName": "@ni/eslint-config-angular", | ||
"email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
"dependentChangeType": "patch" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@ni-eslint-config-javascript-8342b44c-c3b9-4617-ac3e-8f4c3a14962c.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "major", | ||
"comment": "Update eslint-config-javascript to be compatible with eslint v9. See [Migration Guide](https://github.com/ni/javascript-styleguide/blob/main/README.md#migrating-to-eslint-flat-configuration-format) for more information.", | ||
"packageName": "@ni/eslint-config-javascript", | ||
"email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
"dependentChangeType": "patch" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@ni-eslint-config-playwright-854caf08-4e79-4f67-b93a-441aa8e94aa6.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "major", | ||
"comment": "Update eslint-config-playwright to be compatible with eslint v9. Change default rule configuration to assume `strictNullChecks` is enabled. See [Migration Guide](https://github.com/ni/javascript-styleguide/blob/main/README.md#migrating-to-eslint-flat-configuration-format) for more information.", | ||
"packageName": "@ni/eslint-config-playwright", | ||
"email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
"dependentChangeType": "patch" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@ni-eslint-config-typescript-59a461d7-a675-4c63-b3e9-5504d06ec44f.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "major", | ||
"comment": "Update eslint-config-typescript to be compatible with eslint v9. Change default rule configuration to assume `strictNullChecks` is enabled. See [Migration Guide](https://github.com/ni/javascript-styleguide/blob/main/README.md#migrating-to-eslint-flat-configuration-format) for more information.", | ||
"packageName": "@ni/eslint-config-typescript", | ||
"email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
"dependentChangeType": "patch" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.