feat: Add support for Measurement Remote Execution by populating deployment_target #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Apart from these comments, I'll let @Avinash2Suresh review the automated tests once they're added for these updates.
packages/service/ni_measurement_plugin_sdk_service/discovery/_client.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/measurement/info.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/measurement/info.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/measurement/info.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/measurement/info.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_drivers/_grpcdevice.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_drivers/_grpcdevice.py
Outdated
Show resolved
Hide resolved
Avinash2Suresh
requested review from
bkeryan,
csjall,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
bkeryan
requested changes
Jul 9, 2025
packages/service/ni_measurement_plugin_sdk_service/session_management/_client.py
Outdated
Show resolved
Hide resolved
divakar-selvam07
force-pushed
the
users/diva/populate-deployment-target-in-clients
branch
from
0560c69 to
25aab35
Compare
bkeryan
reviewed
Jul 10, 2025
packages/service/ni_measurement_plugin_sdk_service/discovery/_client.py
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
Jul 10, 2025
2 tasks
bkeryan
approved these changes
Jul 11, 2025
jayaseelan-james
approved these changes
Jul 14, 2025
packages/service/ni_measurement_plugin_sdk_service/_drivers/_grpcdevice.py
Outdated
Show resolved
Hide resolved
divakar-selvam07
deleted the
users/diva/populate-deployment-target-in-clients
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This Pull Request implements support for the Feature 3069888: Execute measurement plug-ins using remote instruments with Session Management.
It enables accessing instrument resources hosted on a remote test bench machine from developer machines. To achieve this, the
EnumerateComputeNodesAPI that returns the remote test bench URL as a compute node is implemented in theDiscoveryClientand integrated into the service clients:These clients use the
EnumerateComputeNodesAPI to detect remote compute nodes and populate thedeployment_targetaccordingly. As a result, all service requests are resolved and sent to the appropriate remote services instead of the local host. If no remote compute nodes are found, the system falls back to the current local behavior.Why should this Pull Request be merged?
This change is essential for enabling seamless execution of measurement plug-ins using remote instrument resources. By allowing service clients to resolve and communicate with remote services transparently, developers can work remotely without changing existing workflows.
What testing has been done?
Written automated tests and manually verified the behavior using the Argo installer.
Additional references: