Skip to content

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Sep 18, 2025

What does this Pull Request accomplish?

Rewrite the publish workflow to use GitHub as a PyPI "Trusted Publisher" and create a PR to update the project versions.

Why should this Pull Request be merged?

Improve security

Closes #162

What testing has been done?

Ran workflow manually with environment=testpypi: https://github.com/ni/measurement-plugin-python/actions/runs/17844168026
We haven't created TestPyPI projects for this repo's packages, so it failed, but this may be adequate.
It created this version update PR: #1229

Copy link
Contributor

github-actions bot commented Sep 19, 2025

Test Results

    52 files  ±0      52 suites  ±0   1h 14m 50s ⏱️ - 2m 30s
   689 tests ±0     689 ✅ ±0      0 💤 ±0  0 ❌ ±0 
20 700 runs  ±0  19 644 ✅ ±0  1 056 💤 ±0  0 ❌ ±0 

Results for commit d6bd17d. ± Comparison against base commit 3da9aed.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan merged commit 75a9c9c into main Sep 19, 2025
39 of 43 checks passed
@bkeryan bkeryan deleted the users/bkeryan/trusted-publishing branch September 19, 2025 20:38
dixonjoel pushed a commit that referenced this pull request Sep 30, 2025
* github: Rewrite publish workflow

* github: Fix dist path

* github: Make publish_examples work with workflow_call

* github: Fix quoting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source code archive for each release uses the previous release's version number
2 participants