Skip to content

Conversation

dixonjoel
Copy link
Collaborator

What does this Pull Request accomplish?

Changes the name of the plugin generator command to ni-measurement-plugin-generator.
image

Why should this Pull Request be merged?

We want to change the way users invoke the generator so they don't get confused. ni-measurement-plugin-sdk-generator could indicate you're 'generating a plugin SDK'.

What testing has been done?

Ran the tool locally.

@dixonjoel dixonjoel requested review from bkeryan and csjall as code owners July 15, 2024 15:58
Copy link
Contributor

Test Results

    30 files  ±0      30 suites  ±0   46m 24s ⏱️ +22s
   653 tests ±0     653 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 210 runs  ±0  15 150 ✅ ±0  1 060 💤 ±0  0 ❌ ±0 

Results for commit 9e4a570. ± Comparison against base commit ac37644.

@bkeryan
Copy link
Collaborator

bkeryan commented Jul 15, 2024

@dixonjoel Will the client generator be part of the same PyPI package and named ni-measurement-client-generator?

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is ok

@dixonjoel
Copy link
Collaborator Author

@dixonjoel Will the client generator be part of the same PyPI package and named ni-measurement-client-generator?

I'm not sure about if it'll be in the same packages, but yes, I think that's what @rfriedma and I talked about.

@dixonjoel dixonjoel merged commit eb6486f into main Jul 15, 2024
@dixonjoel dixonjoel deleted the users/jdixon/update-generator-command-name branch July 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants