Bug/bug195 #206
Merged
Bug/bug195 #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 30, 2017 16:41
marcoskirsch
requested changes
Aug 30, 2017
src/nifake/metadata/functions.py
Outdated
| 'direction': 'in', | ||
| 'enum': None, | ||
| 'name': 'aNumber', | ||
| 'type': 'ViInt16', |
src/nifake/metadata/functions.py
Outdated
| 'direction': 'in', | ||
| 'enum': None, | ||
| 'name': 'aNumber2', | ||
| 'type': 'ViInt16', |
There was a problem hiding this comment.
try a different data type - we already tested ViInt16
src/nifake/tests/test_session.py
Outdated
| lib1 = session.library | ||
| with nifake.Session('dev1') as session: | ||
| lib2 = session.library | ||
| assert lib1 == lib2 |
There was a problem hiding this comment.
lib1 is lib2
(you don't want to compare, you want to ensure it's the same exact instance)
src/nifake/tests/test_session.py
Outdated
| def test_library_singleton(self): | ||
| with nifake.Session('dev1') as session: | ||
| lib1 = session.library | ||
| with nifake.Session('dev1') as session: |
added 2 commits
August 30, 2017 17:23
texasaggie97-zz
approved these changes
Aug 30, 2017
marcoskirsch
approved these changes
Aug 31, 2017
# Conflicts: # generated/command_history.bat # generated/command_history.sh # generated/nifake/ctypes_library.py # generated/nifake/tests/test_session.py # src/nidmm/system_tests/test_system_nidmm.py # src/nifake/tests/test_session.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ x] This contribution adheres to [CONTRIBUTING.md]
What does this Pull Request accomplish?
Fixes #195
Why should this Pull Request be merged?
It increases the unit test coverage of NI-FAKE, adds additional NI-FAKE functions, and reduces system test redundancy.
What testing has been done?
Run Unit Tests and System Tests