Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make username visible for NuGet #10

Merged
merged 25 commits into from
Mar 29, 2023
Merged

Make username visible for NuGet #10

merged 25 commits into from
Mar 29, 2023

Conversation

innagarc
Copy link
Collaborator

@innagarc innagarc commented Mar 29, 2023 •
edited
Loading

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Making the username visible in case of authentication_basic.

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Automated change when I tried to build locally.

Does this introduce a breaking change?

  • Yes
  • No

innagarc and others added 24 commits March 20, 2023 10:49
@innagarc
Created service end point for NuGet
444b6c0
@innagarc
Create documentation
49a4a40
@innagarc
Minor fixes
631bd49
@innagarc
Modelled along the lines of jfrog_artifactory_v2
b9e4803
@innagarc
Fix doc as per JFrog V2
c35b828
@innagarc
Added the third variant
73cef00
@innagarc
Fix implementation
390216c
@innagarc
Fix nugetkey
db16caf
@innagarc
Merge branch 'ni-main' into users/innagarc/add-nuget-service-conn
6f4e85d
@innagarc
Cleanup
2ab7aa2
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
cc2f55d 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
2bb1f91 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
06b8799 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
c921b81 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
e7f1f3f 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
a411c09 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
98144e4 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
6abeb4e 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc @davidcorrigan714
Update azuredevops/internal/service/serviceendpoint/resource_servicee…
67c3e20 
…ndpoint_nuget.go

Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@innagarc
Put fixes after addressing review comments
38b0a28
@innagarc
Fixing NuGet build issues
51aaa4e
@innagarc
Merge
462143a
@innagarc
Fix build
4cd086f
@innagarc
Added additional change since we are making username visible for nuget
60b1c74
@innagarc innagarc changed the title Fixed build issues with NuGet Fix build issues with NuGet Mar 29, 2023
@innagarc innagarc closed this Mar 29, 2023
@innagarc innagarc reopened this Mar 29, 2023
@innagarc innagarc changed the title Fix build issues with NuGet Make username visible for NuGet Mar 29, 2023
@davidcorrigan714 davidcorrigan714 merged commit 3a39eba into ni:ni-main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcorrigan714 davidcorrigan714 davidcorrigan714 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@innagarc @davidcorrigan714