Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hide_zero option #2958

Closed
nicolargo opened this issue Oct 5, 2024 · 3 comments
Closed

Improve hide_zero option #2958

nicolargo opened this issue Oct 5, 2024 · 3 comments

Comments

@nicolargo
Copy link
Owner

After the implementation of #2929

Some improvement will be useful:

  • Of course now that I see it I think hide_threshold_bytes also makes sense, so the tiny 14K writes don't show up. See Of course now that I see it I think hide_threshold_bytes also makes sense, so the tiny 14K writes don't show up.
  • Also while I'm at it, a small delay before removing it from the list could make sense. Sort of debounce the removal so if activity drops for a few seconds then picks back up the entry doesn't phase in and out. See Also while I'm at it, a small delay before removing it from the list could make sense. Sort of debounce the removal so if activity drops for a few seconds then picks back up the entry doesn't phase in and out.
Copy link

github-actions bot commented Oct 5, 2024

This issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution ! ✨

@nicolargo
Copy link
Owner Author

Thanks again @Tacitor

In the PR i have change the line from:

if field in self.hide_zero_fields and i[field] >= self.hide_threshold_bytes:

to:

if field in self.hide_zero_fields and i[field] > self.hide_threshold_bytes:

And add some documentation for the new option.

@Tacitor
Copy link
Contributor

Tacitor commented Oct 23, 2024

You're welcome, my pleasure!

Thanks for taking care of the documentation. For any future contributions I'll be sure to do that as well.

@nicolargo nicolargo modified the milestones: Glances 4.3.0, Glances 4.2.1 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants