Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide option to sensors plugin #1596

Closed
wants to merge 1 commit into from

Conversation

cdeletre
Copy link

@cdeletre cdeletre commented Feb 7, 2020

Description

This pull request proposes to add the support of hide option to the sensors plugin. It may be useful when you want to hide core temperatures and only show main CPU temp of 10+ core CPUs.

Resume

  • Bug fix: no
  • New feature: yes
  • Fixed tickets: N/A

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 39.558% when pulling 72a4428 on cdeletre:develop into 3e5ec44 on nicolargo:develop.

@@ -127,14 +127,20 @@ def update(self):

pass

# Set the alias for each stat
# Update the stats
self.stats = []
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea what would be the best, and good, way to implement the hide option. I have supposed there is no sync issue doing this way, using no temporary variable.

@nicolargo nicolargo linked an issue Feb 16, 2020 that may be closed by this pull request
@nicolargo
Copy link
Owner

Done in version 3.1.4.

Thanks for the PR @cdeletre

@nicolargo nicolargo closed this Apr 26, 2020
@modelrockettier
Copy link

@nicolargo is it possible to reapply this pull?

It looks like somehow it didn't make it into either version 3.1.4 or the develop branch.

@distributorofpain
Copy link

Does this mean i can set the alias=hide and it will hide the senor? Assuming its put back in 3.1.5...

@modelrockettier
Copy link

Not exactly, but similar. It follows the other plugin style of:

hide=Sensor 1,Sensor 3

@distributorofpain
Copy link

distributorofpain commented Sep 8, 2020

oh, thanks for the clarification! That makes perfect sense, i hadnt used the hide function yet and when i searched the docs for hide sensor it wasnt shown as available(so i didnt try it).

Edit: not working 3.1.5, could of sworn i saw it working....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide function in sensors section
5 participants