Comment #189

nicolay-r · Sep 12, 2021 · 0a91593 · 0a91593
1 parent 2795001
commit 0a91593
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/arekit/common/experiment/cv/doc_stat/base.py b/arekit/common/experiment/cv/doc_stat/base.py
@@ -1,3 +1,6 @@
+# TODO. depends on io, issue #189
+# TODO. Rename as BaseDocumentStatProvider!
+# TODO. Move into the particular experiment issue #189
 class BaseDocumentStatGenerator(object):
     """
     Provides statistic on certain document.
@@ -24,6 +27,7 @@ def _calc(self, news):
 
     # region public methods
 
+    # TODO. depends on io, issue #189
     def calculate_and_write_doc_stat(self, filepath, doc_ids_iter):
         with open(filepath, 'w') as f:
             for doc_id in doc_ids_iter:

diff --git a/arekit/common/experiment/cv/doc_stat/sentence.py b/arekit/common/experiment/cv/doc_stat/sentence.py
@@ -2,6 +2,9 @@
 from arekit.common.news.base import News
 
 
+# TODO. depends on io, issue #189
+# TODO. We should not adopt inheritance there!
+# TODO. Move into the particular experiment issue #189
 class SentenceBasedDocumentStatGenerator(BaseDocumentStatGenerator):
 
     def __init__(self, doc_reader_func):

diff --git a/arekit/common/experiment/cv/splitters/statistical.py b/arekit/common/experiment/cv/splitters/statistical.py
@@ -4,6 +4,7 @@
 from arekit.common.experiment.cv.splitters.base import CrossValidationSplitter
 
 
+# TODO. Move into the particular experiment issue #189
 class StatBasedCrossValidataionSplitter(CrossValidationSplitter):
     """ Sentence-based splitter.
     """