Skip to content

Commit

Permalink
#376 related todo.
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolay-r committed Jul 25, 2022
1 parent bd6dd0e commit 4a5b638
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 0 additions & 2 deletions arekit/common/data/row_ids/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ class BaseIDProvider(object):
Since we are head to remove opinions, there is a need to refactor so in a
way of an additional column that provides such information for further connection
between rows of different storages.
#
"""

SEPARATOR = '_'
Expand Down
2 changes: 2 additions & 0 deletions arekit/common/data/row_ids/binary.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
class BinaryIDProvider(BaseIDProvider):
"""
Considered that label of opinion IS A PART OF id.
# TODO. #376 related. This should be removed after refactoring, because
# TODO. we consider an ordinary IDs, that not based on the other data.
"""

LABEL = 'l{}' + BaseIDProvider.SEPARATOR
Expand Down
2 changes: 2 additions & 0 deletions arekit/common/data/row_ids/multiple.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
class MultipleIDProvider(BaseIDProvider):
"""
Considered that label of opinion is not a part of id.
# TODO. #376 related. This should be removed after refactoring, because
# TODO. we consider an ordinary IDs, that not based on the other data.
"""

@staticmethod
Expand Down

0 comments on commit 4a5b638

Please sign in to comment.