Skip to content

Commit

Permalink
#462 fix
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolay-r committed May 17, 2023
1 parent 03e30f5 commit 6af32de
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
9 changes: 8 additions & 1 deletion arekit/contrib/utils/data/ext.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
from arekit.contrib.utils.data.readers.base import BaseReader
from arekit.contrib.utils.data.readers.csv_pd import PandasCsvReader
from arekit.contrib.utils.data.writers.base import BaseWriter
from arekit.contrib.utils.data.writers.csv_native import NativeCsvWriter
from arekit.contrib.utils.data.writers.csv_pd import PandasCsvWriter
from arekit.contrib.utils.data.writers.json_opennre import OpenNREJsonWriter


PANDAS_CSV_EXTENSION = ".tsv.gz"
OPENNRE_EXTENSION = ".jsonl"


def create_writer_extension(writer):
assert(isinstance(writer, BaseWriter))

if isinstance(writer, OpenNREJsonWriter):
return ".json"
return OPENNRE_EXTENSION
if isinstance(writer, PandasCsvWriter):
return PANDAS_CSV_EXTENSION
if isinstance(writer, NativeCsvWriter):
return ".csv"

raise NotImplementedError()

Expand All @@ -23,5 +28,7 @@ def create_reader_extension(writer):

if isinstance(writer, PandasCsvReader):
return PANDAS_CSV_EXTENSION
if isinstance(writer, OpenNREJsonWriter):
return OPENNRE_EXTENSION

raise NotImplementedError()
3 changes: 0 additions & 3 deletions arekit/contrib/utils/data/readers/jsonl.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,3 @@ def read(self, target):
for line in f.readlines():
rows.append(line)
return JsonlBasedRowsStorage(rows)

def target_extension(self):
return ".jsonl"

0 comments on commit 6af32de

Please sign in to comment.