Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedding -- set_stemmer method is not declared in base class #114

Closed
nicolay-r opened this issue May 6, 2021 · 0 comments
Closed

Embedding -- set_stemmer method is not declared in base class #114

nicolay-r opened this issue May 6, 2021 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

in to_tsv_with_embedding_and_vocabulary we setup stemmer for predefined_embedding. This action is incorrect in general, as base WordEmbedding class does not provide the related method.
@nicolay-r nicolay-r added the enhancement New feature or request label May 6, 2021
@nicolay-r nicolay-r self-assigned this May 6, 2021
nicolay-r added a commit that referenced this issue May 6, 2021
@nicolay-r
Fixed #114. This operation relies on the extertal code.
f8d4755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r